8000 Trace: add VPC SC test by lunajrq · Pull Request #5193 · googleapis/google-cloud-java · GitHub
[go: up one dir, main page]
Skip to content

Trace: add VPC SC test #5193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chingor13 merged 1 commit into from
May 21, 2019
Merged

Trace: add VPC SC test #5193

chingor13 merged 1 commit into from
May 21, 2019

Conversation

@lunajrq
Copy link
Contributor
@lunajrq lunajrq commented May 16, 2019

This new file is added in order to test client lib compatibility of VPC SC. The tests can be run inside or outside of VPC service perimeter. The input to the script should be the following environment variables.

PROJECT_ID: a project that is inside the VPC perimeter.
GOOGLE_CLOUD_TESTS_VPCSC_OUTSIDE_PERIMETER_PROJECT: a project that is outside the VPC perimeter.

@lunajrq lunajrq requested a review from a team as a code owner May 16, 2019 21:32
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 16, 2019
@sduskis sduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 17, 2019
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels May 17, 2019
@codecov
Copy link
codecov bot commented May 17, 2019 •
edited
Loading

Codecov Report

Merging #5193 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5193      +/-   ##
============================================
+ Coverage      50.4%   50.41%   +0.01%     
- Complexity    23786    23811      +25     
============================================
  Files          2251     2251              
  Lines        226792   226833      +41     
  Branches      24966    24961       -5     
============================================
+ Hits         114322   114368      +46     
+ Misses       103864   103858       -6     
- Partials       8606     8607       +1
Impacted Files Coverage Δ Complexity Δ
...able/gaxx/reframing/ReframingResponseObserver.java 88.99% <0%> (-1.84%) 29% <0%> (-1%)
...e/cloud/dialogflow/v2beta1/stub/DocumentsStub.java 8.33% <0%> (-0.76%) 1% <0%> (ø)
...le/cloud/dialogflow/v2beta1/DocumentsSettings.java 15.55% <0%> (-0.73%) 2% <0%> (ø)
...dialogflow/v2beta1/stub/DocumentsStubSettings.java 86.36% <0%> (+1.38%) 19% <0%> (+1%) ⬆️
...oud/dialogflow/v2beta1/stub/GrpcDocumentsStub.java 90.18% <0%> (+2.13%) 13% <0%> (+1%) ⬆️
...ogle/cloud/dialogflow/v2beta1/DocumentsClient.java 55.17% <0%> (+3.36%) 23% <0%> (+4%) ⬆️
...cloud/dialogflow/v2beta1/KnowledgeBasesClient.java 58.42% <0%> (+3.77%) 23% <0%> (+4%) ⬆️
...ialogflow/v2beta1/stub/GrpcKnowledgeBasesStub.java 92.36% <0%> (+3.81%) 12% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b98115...b7fecb8. Read the comment docs.

@lunajrq
Copy link
Contributor Author
lunajrq commented May 21, 2019

Friendly Ping
Could anyone help reviewing this pr for me?

@chingor13 chingor13 self-assigned this May 21, 2019
chingor13
chingor13 approved these changes May 21, 2019
View reviewed changes
Copy link
Contributor
@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chingor13 chingor13 merged commit 720d901 into googleapis:master May 21, 2019
This was referenced May 22, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chingor13 chingor13 chingor13 approved these changes

Assignees

@chingor13 chingor13

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lunajrq @chingor13 @sduskis @googlebot @yoshi-kokoro
0