fix(core): Ensure ignoreErrors only applies to error events (getsentry#7573)

mydea · web-flow · commit 0a1a567bc3ec · 2023-03-23T08:15:35.000Z
diff --git a/packages/core/src/integrations/inboundfilters.ts b/packages/core/src/integrations/inboundfilters.ts
@@ -103,7 +103,8 @@ export function _shouldDropEvent(event: Event, options: Partial<InboundFiltersOp
 }
 
 function _isIgnoredError(event: Event, ignoreErrors?: Array<string | RegExp>): boolean {
-  if (!ignoreErrors || !ignoreErrors.length) {
+  // If event.type, this is not an error
+  if (event.type || !ignoreErrors || !ignoreErrors.length) {
     return false;
   }
 
diff --git a/packages/core/test/lib/integrations/inboundfilters.test.ts b/packages/core/test/lib/integrations/inboundfilters.test.ts
@@ -177,6 +177,11 @@ const MALFORMED_EVENT: Event = {
   },
 };
 
+const TRANSACTION_EVENT: Event = {
+  message: 'transaction message',
+  type: 'transaction',
+};
+
 describe('InboundFilters', () => {
   describe('_isSentryError', () => {
     it('should work as expected', () => {
@@ -202,6 +207,13 @@ describe('InboundFilters', () => {
       expect(eventProcessor(MESSAGE_EVENT, {})).toBe(null);
     });
 
+    it('ignores transaction event for filtering', () => {
+      const eventProcessor = createInboundFiltersEventProcessor({
+        ignoreErrors: ['transaction'],
+      });
+      expect(eventProcessor(TRANSACTION_EVENT, {})).toBe(TRANSACTION_EVENT);
+    });
+
     it('string filter with exact match', () => {
       const eventProcessor = createInboundFiltersEventProcessor({
         ignoreErrors: ['captureMessage'],

Original file line number	Diff line number	Diff line change
`@@ -103,7 +103,8 @@ export function _shouldDropEvent(event: Event, options: Partial<InboundFiltersOp`
`103`	`103`	`}`
`104`	`104`
`105`	`105`	`function _isIgnoredError(event: Event, ignoreErrors?: Array<string \| RegExp>): boolean {`
`106`		`- if (!ignoreErrors \|\| !ignoreErrors.length) {`
	`106`	`+ // If event.type, this is not an error`
	`107`	`+ if (event.type \|\| !ignoreErrors \|\| !ignoreErrors.length) {`
`107`	`108`	`return false;`
`108`	`109`	`}`
`109`	`110`