Minor test code cleanup

nulltoken · nulltoken · commit fc59d2e8657c · 2015-03-17T07:57:45.000+01:00
diff --git a/LibGit2Sharp.Tests/BranchFixture.cs b/LibGit2Sharp.Tests/BranchFixture.cs
@@ -443,8 +443,8 @@ public void QueryAmbigousRemoteForRemoteBranch()
         {
             var path = SandboxStandardTestRepo();
 
-            var fetchRefSpec = "+refs/heads/*:refs/remotes/origin/*";
-            var url = "http://github.com/libgit2/TestGitRepository";
+            const string fetchRefSpec = "+refs/heads/*:refs/remotes/origin/*";
+            const string url = "http://github.com/libgit2/TestGitRepository";
 
             using (var repo = InitIsolatedRepository(path))
             {
diff --git a/LibGit2Sharp.Tests/CheckoutFixture.cs b/LibGit2Sharp.Tests/CheckoutFixture.cs
@@ -9,10 +9,10 @@ namespace LibGit2Sharp.Tests
 {
     public class CheckoutFixture : BaseFixture
     {
-        private static readonly string originalFilePath = "a.txt";
-        private static readonly string originalFileContent = "Hello";
-        private static readonly string alternateFileContent = "There again";
-        private static readonly string otherBranchName = "other";
+        private const string originalFilePath = "a.txt";
+        private const string originalFileContent = "Hello";
+        private const string alternateFileContent = "There again";
+        private const string otherBranchName = "other";
 
         [Theory]
         [InlineData("i-do-numbers")]
@@ -319,7 +319,7 @@ public void CanCancelCheckoutThroughNotifyCallback()
 
             using (var repo = new Repository(repoPath))
             {
-                string relativePath = "a.txt";
+                const string relativePath = "a.txt";
                 Touch(repo.Info.WorkingDirectory, relativePath, "Hello\n");
 
                 repo.Stage(relativePath);
@@ -451,13 +451,13 @@ public void CheckingOutCallsCheckoutNotify(CheckoutNotifyFlags notifyFlags, stri
             {
                 PopulateBasicRepository(repo);
 
-                string relativePathUpdated = "updated.txt";
+                const string relativePathUpdated = "updated.txt";
                 Touch(repo.Info.WorkingDirectory, relativePathUpdated, "updated file text A");
                 repo.Stage(relativePathUpdated);
                 repo.Commit("Commit initial update file", Constants.Signature, Constants.Signature);
 
                 // Create conflicting change
-                string relativePathConflict = "conflict.txt";
+                const string relativePathConflict = "conflict.txt";
                 Touch(repo.Info.WorkingDirectory, relativePathConflict, "conflict file text A");
                 repo.Stage(relativePathConflict);
                 repo.Commit("Initial commit of conflict.txt and update.txt", Constants.Signature, Constants.Signature);
@@ -492,7 +492,7 @@ public void CheckingOutCallsCheckoutNotify(CheckoutNotifyFlags notifyFlags, stri
                 Touch(repo.Info.WorkingDirectory, relativePathIgnore, "ignored file");
 
                 // Create untracked change
-                string relativePathUntracked = "untracked.txt";
+                const string relativePathUntracked = "untracked.txt";
                 Touch(repo.Info.WorkingDirectory, relativePathUntracked, "untracked file");
 
                 bool wasCalled = false;
diff --git a/LibGit2Sharp.Tests/MockingFixture.cs b/LibGit2Sharp.Tests/MockingFixture.cs
@@ -73,8 +73,8 @@ public int NumberOfCommits
         [Fact]
         public void CanFakeConfigurationBuildSignature()
         {
-            var name = "name";
-            var email = "email";
+            const string name = "name";
+            const string email = "email";
             var now = DateTimeOffset.UtcNow;
 
             var fakeConfig = new Mock<Configuration>();

Original file line number	Diff line number	Diff line change
`@@ -443,8 +443,8 @@ public void QueryAmbigousRemoteForRemoteBranch()`
`443`	`443`	`{`
`444`	`444`	`var path = SandboxStandardTestRepo();`
`445`	`445`
`446`		`- var fetchRefSpec = "+refs/heads/:refs/remotes/origin/";`
`447`		`- var url = "http://github.com/libgit2/TestGitRepository";`
	`446`	`+ const string fetchRefSpec = "+refs/heads/:refs/remotes/origin/";`
	`447`	`+ const string url = "http://github.com/libgit2/TestGitRepository";`
`448`	`448`
`449`	`449`	`using (var repo = InitIsolatedRepository(path))`
`450`	`450`	`{`