8000 Unskip include-tag related fetch tests · GiTechLab/libgit2sharp@afbe73e · GitHub
[go: up one dir, main page]

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit afbe73e

Browse files
committed
Unskip include-tag related fetch tests
Due to a recent GitHub policy change, those tests now pass
1 parent 3b0f7e1 commit afbe73e

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

LibGit2Sharp.Tests/FetchFixture.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ public class FetchFixture : BaseFixture
1010
{
1111
private const string remoteName = "testRemote";
1212

13-
[Theory(Skip = "Skipping due to recent github handling modification of --include-tag.")]
13+
[Theory]
1414
[InlineData("http://github.com/libgit2/TestGitRepository")]
1515
[InlineData("https://github.com/libgit2/TestGitRepository")]
1616
[InlineData("git://github.com/libgit2/TestGitRepository.git")]
@@ -150,7 +150,7 @@ public void CanFetchCustomRefSpecsIntoAnEmptyRepository(string url, string local
150150
[Theory]
151151
[InlineData(TagFetchMode.All, 4)]
152152
[InlineData(TagFetchMode.None, 0)]
153-
//[InlineData(TagFetchMode.Auto, 3)] // TODO: Skipping due to github modification of --include-tag handling."
153+
[InlineData(TagFetchMode.Auto, 3)]
154154
public void FetchRespectsConfiguredAutoTagSetting(TagFetchMode tagFetchMode, int expectedTagCount)
155155
{
156156
string url = "http://github.com/libgit2/TestGitRepository";

LibGit2Sharp.Tests/RepositoryFixture.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ private static void AssertIsHidden(string repoPath)
150150
Assert.Equal(FileAttributes.Hidden, (attribs & FileAttributes.Hidden));
151151
}
152152

153-
[Fact(Skip = "Skipping due to recent github handling modification of --include-tag.")]
153+
[Fact]
154154
public void CanFetchFromRemoteByName()
155155
{
156156
string remoteName = "testRemote";

LibGit2Sharp.Tests/SmartSubtransportFixture.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ public void CustomSmartSubtransportTest(string scheme, string url)
5555
}
5656

5757
// Add the expected tags
58-
string[] expectedTagNames = { "blob", "commit_tree" };
58+
string[] expectedTagNames = { "blob", "commit_tree", "annotated_tag" };
5959
foreach (string tagName in expectedTagNames)
6060
{
6161
TestRemoteInfo.ExpectedTagInfo expectedTagInfo = expectedResults.Tags[tagName];

0 commit comments

Comments
 (0)
0