Hide GitCredentialType from public API

nulltoken · nulltoken · commit 9d91bd5ae31a · 2015-02-12T23:12:57.000+01:00
diff --git a/LibGit2Sharp/Core/GitCredentialType.cs b/LibGit2Sharp/Core/GitCredentialType.cs
@@ -6,7 +6,7 @@ namespace LibGit2Sharp.Core
     /// Authentication type requested.
     /// </summary>
     [Flags]
-    public enum GitCredentialType
+    internal enum GitCredentialType
     {
         /// <summary>
         /// A plaintext username and password.
diff --git a/LibGit2Sharp/Credentials.cs b/LibGit2Sharp/Credentials.cs
@@ -12,11 +12,7 @@ public abstract class Credentials
         /// Callback to acquire a credential object.
         /// </summary>
         /// <param name="cred">The newly created credential object.</param>
-        /// <param name="url">The resource for which we are demanding a credential.</param>
-        /// <param name="usernameFromUrl">The username that was embedded in a "user@host"</param>
-        /// <param name="types">A bitmask stating which cred types are OK to return.</param>
-        /// <param name="payload">The payload provided when specifying this callback.</param>
         /// <returns>0 for success, &lt; 0 to indicate an error, &gt; 0 to indicate no credential was acquired.</returns>
-        protected internal abstract int GitCredentialHandler(out IntPtr cred, IntPtr url, IntPtr usernameFromUrl, GitCredentialType types, IntPtr payload);
+        protected internal abstract int GitCredentialHandler(out IntPtr cred);
     }
 }
diff --git a/LibGit2Sharp/DefaultCredentials.cs b/LibGit2Sharp/DefaultCredentials.cs
@@ -13,12 +13,8 @@ public sealed class DefaultCredentials : Credentials
         /// Callback to acquire a credential object.
         /// </summary>
         /// <param name="cred">The newly created credential object.</param>
-        /// <param name="url">The resource for which we are demanding a credential.</param>
-        /// <param name="usernameFromUrl">The username that was embedded in a "user@host"</param>
-        /// <param name="types">A bitmask stating which cred types are OK to return.</param>
-        /// <param name="payload">The payload provided when specifying this callback.</param>
         /// <returns>0 for success, &lt; 0 to indicate an error, &gt; 0 to indicate no credential was acquired.</returns>
-        protected internal override int GitCredentialHandler(out IntPtr cred, IntPtr url, IntPtr usernameFromUrl, GitCredentialType types, IntPtr payload)
+        protected internal override int GitCredentialHandler(out IntPtr cred)
         {
             return NativeMethods.git_cred_default_new(out cred);
         }
diff --git a/LibGit2Sharp/RemoteCallbacks.cs b/LibGit2Sharp/RemoteCallbacks.cs
@@ -223,7 +223,7 @@ private int GitCredentialHandler(out IntPtr ptr, IntPtr cUrl, IntPtr usernameFro
 
             var cred = CredentialsProvider(url, username, types);
 
-            return cred.GitCredentialHandler(out ptr, cUrl, usernameFromUrl, credTypes, payload);
+            return cred.GitCredentialHandler(out ptr);
         }
 
         #endregion
diff --git a/LibGit2Sharp/UsernamePasswordCredentials.cs b/LibGit2Sharp/UsernamePasswordCredentials.cs
@@ -12,12 +12,8 @@ public sealed class UsernamePasswordCredentials : Credentials
         /// Callback to acquire a credential object.
         /// </summary>
         /// <param name="cred">The newly created credential object.</param>
-        /// <param name="url">The resource for which we are demanding a credential.</param>
-        /// <param name="usernameFromUrl">The username that was embedded in a "user@host"</param>
-        /// <param name="types">A bitmask stating which cred types are OK to return.</param>
-        /// <param name="payload">The payload provided when specifying this callback.</param>
         /// <returns>0 for success, &lt; 0 to indicate an error, &gt; 0 to indicate no credential was acquired.</returns>
-        protected internal override int GitCredentialHandler(out IntPtr cred, IntPtr url, IntPtr usernameFromUrl, GitCredentialType types, IntPtr payload)
+        protected internal override int GitCredentialHandler(out IntPtr cred)
         {
             if (Username == null || Password == null)
             {

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@ namespace LibGit2Sharp.Core`
`6`	`6`	`/// Authentication type requested.`
`7`	`7`	`/// </summary>`
`8`	`8`	`[Flags]`
`9`		`- public enum GitCredentialType`
	`9`	`+ internal enum GitCredentialType`
`10`	`10`	`{`
`11`	`11`	`/// <summary>`
`12`	`12`	`/// A plaintext username and password.`
Original file line number	Diff line number	Diff line change
`@@ -12,11 +12,7 @@ public abstract class Credentials`
`12`	`12`	`/// Callback to acquire a credential object.`
`13`	`13`	`/// </summary>`
`14`	`14`	`/// <param name="cred">The newly created credential object.</param>`
`15`		`- /// <param name="url">The resource for which we are demanding a credential.</param>`
`16`		`- /// <param name="usernameFromUrl">The username that was embedded in a "user@host"</param>`
`17`		`- /// <param name="types">A bitmask stating which cred types are OK to return.</param>`
`18`		`- /// <param name="payload">The payload provided when specifying this callback.</param>`
`19`	`15`	`/// <returns>0 for success, < 0 to indicate an error, > 0 to indicate no credential was acquired.</returns>`
`20`		`- protected internal abstract int GitCredentialHandler(out IntPtr cred, IntPtr url, IntPtr usernameFromUrl, GitCredentialType types, IntPtr payload);`
	`16`	`+ protected internal abstract int GitCredentialHandler(out IntPtr cred);`
`21`	`17`	`}`
`22`	`18`	`}`
Original file line number	Diff line number	Diff line change
`@@ -13,12 +13,8 @@ public sealed class DefaultCredentials : Credentials`
`13`	`13`	`/// Callback to acquire a credential object.`
`14`	`14`	`/// </summary>`
`15`	`15`	`/// <param name="cred">The newly created credential object.</param>`
`16`		`- /// <param name="url">The resource for which we are demanding a credential.</param>`
`17`		`- /// <param name="usernameFromUrl">The username that was embedded in a "user@host"</param>`
`18`		`- /// <param name="types">A bitmask stating which cred types are OK to return.</param>`
`19`		`- /// <param name="payload">The payload provided when specifying this callback.</param>`
`20`	`16`	`/// <returns>0 for success, < 0 to indicate an error, > 0 to indicate no credential was acquired.</returns>`
`21`		`- protected internal override int GitCredentialHandler(out IntPtr cred, IntPtr url, IntPtr usernameFromUrl, GitCredentialType types, IntPtr payload)`
	`17`	`+ protected internal override int GitCredentialHandler(out IntPtr cred)`
`22`	`18`	`{`
`23`	`19`	`return NativeMethods.git_cred_default_new(out cred);`
`24`	`20`	`}`
Original file line number	Diff line number	Diff line change
`@@ -223,7 +223,7 @@ private int GitCredentialHandler(out IntPtr ptr, IntPtr cUrl, IntPtr usernameFro`
`223`	`223`
`224`	`224`	`var cred = CredentialsProvider(url, username, types);`
`225`	`225`
`226`		`- return cred.GitCredentialHandler(out ptr, cUrl, usernameFromUrl, credTypes, payload);`
	`226`	`+ return cred.GitCredentialHandler(out ptr);`
`227`	`227`	`}`
`228`	`228`
`229`	`229`	`#endregion`
Original file line number	Diff line number	Diff line change
`@@ -12,12 +12,8 @@ public sealed class UsernamePasswordCredentials : Credentials`
`12`	`12`	`/// Callback to acquire a credential object.`
`13`	`13`	`/// </summary>`
`14`	`14`	`/// <param name="cred">The newly created credential object.</param>`
`15`		`- /// <param name="url">The resource for which we are demanding a credential.</param>`
`16`		`- /// <param name="usernameFromUrl">The username that was embedded in a "user@host"</param>`
`17`		`- /// <param name="types">A bitmask stating which cred types are OK to return.</param>`
`18`		`- /// <param name="payload">The payload provided when specifying this callback.</param>`
`19`	`15`	`/// <returns>0 for success, < 0 to indicate an error, > 0 to indicate no credential was acquired.</returns>`
`20`		`- protected internal override int GitCredentialHandler(out IntPtr cred, IntPtr url, IntPtr usernameFromUrl, GitCredentialType types, IntPtr payload)`
	`16`	`+ protected internal override int GitCredentialHandler(out IntPtr cred)`
`21`	`17`	`{`
`22`	`18`	`if (Username == null \|\| Password == null)`
`23`	`19`	`{`