Show typing suggestions for text with whitespace (mentions with full name)

laevandus · laevandus · commit 22df8743d5b6 · 2025-03-11T15:48:42.000+02:00
diff --git a/Sources/StreamChatSwiftUI/ChatChannel/Composer/Suggestions/TypingSuggester.swift b/Sources/StreamChatSwiftUI/ChatChannel/Composer/Suggestions/TypingSuggester.swift
@@ -115,14 +115,9 @@ public struct TypingSuggester {
             return nil
         }
 
-        // Fetch the suggestion text. The suggestions can't have spaces.
-        // valid example: "@luke_skywa..."
-        // invalid example: "@luke skywa..."
+        // Fetch the suggestion text.
         let suggestionLocation = NSRange(location: suggestionStart, length: suggestionEnd - suggestionStart)
         let suggestionText = textString.substring(with: suggestionLocation)
-        guard !suggestionText.contains(" ") else {
-            return nil
-        }
 
         // A minimum number of characters can be provided to only show
         // suggestions after the customer has input enough characters.
diff --git a/StreamChatSwiftUITests/Tests/ChatChannel/Suggestions/TypingSuggester_Tests.swift b/StreamChatSwiftUITests/Tests/ChatChannel/Suggestions/TypingSuggester_Tests.swift
@@ -62,12 +62,12 @@ class TypingSuggester_Tests: XCTestCase {
         XCTAssert(suggestion?.locationRange == NSRange(location: 1, length: 2))
     }
 
-    func test_typingSuggester_notFoundEmptySpace() {
+    func test_typingSuggester_emptySpaceAllowed() {
         // Given
         let options = TypingSuggestionOptions(symbol: "@")
         let typingSuggester = TypingSuggester(options: options)
-        let string = "@M art"
-        let caretLocation = 3
+        let string = "@Han Solo"
+        let caretLocation = 6
 
         // When
         let suggestion = typingSuggester.typingSuggestion(
@@ -76,7 +76,8 @@ class TypingSuggester_Tests: XCTestCase {
         )
 
         // Then
-        XCTAssert(suggestion == nil)
+        XCTAssertEqual("Han S", suggestion?.text)
+        XCTAssertEqual(NSRange(location: 1, length: 5), suggestion?.locationRange)
     }
 
     func test_typingSuggester_notFoundNotOnStart() {
