8000 chore: Add Celery 5 to CI (#839) · GetResQ/sentry-python@867beae · GitHub
[go: up one dir, main page]

8000
Skip to content

Commit 867beae

Browse files
untitakersentry-bot
andauthored
chore: Add Celery 5 to CI (getsentry#839)
Co-authored-by: sentry-bot <markus+ghbot@sentry.io>
1 parent 4d16ef6 commit 867beae

File tree

2 files changed

+16
-5
lines changed

2 files changed

+16
-5
lines changed

tests/integrations/celery/test_celery.py

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,10 +51,19 @@ def inner(propagate_traces=True, backend="always_eager", **kwargs):
5151
request.addfinalizer(lambda: Hub.main.bind_client(None))
5252

5353
# Once we drop celery 3 we can use the celery_worker fixture
54-
w = worker.worker(app=celery)
55-
t = threading.Thread(target=w.run)
56-
t.daemon = True
57-
t.start()
54+
if VERSION < (5,):
55+
worker_fn = worker.worker(app=celery).run
56+
else:
57+
from celery.bin.base import CLIContext
58+
59+
worker_fn = lambda: worker.worker(
60+
obj=CLIContext(app=celery, no_color=True, workdir=".", quiet=False),
61+
args=[],
62+
)
63+
64+
worker_thread = threading.Thread(target=worker_fn)
65+
worker_thread.daemon = True
66+
worker_thread.start()
5867
else:
5968
raise ValueError(backend)
6069

tox.ini

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,10 @@ envlist =
3838
{py3.6,py3.7}-sanic-19
3939

4040
# TODO: Add py3.9
41+
{pypy,py2.7}-celery-3
4142
{pypy,py2.7,py3.5,py3.6}-celery-{4.1,4.2}
4243
{pypy,py2.7,py3.5,py3.6,py3.7,py3.8}-celery-{4.3,4.4}
43-
{pypy,py2.7}-celery-3
44+
{py3.6,py3.7,py3.8}-celery-5.0
4445

4546
{py2.7,py3.7}-beam-{2.12,2.13}
4647

@@ -138,6 +139,7 @@ deps =
138139
celery-4.3: vine<5.0.0
139140
# https://github.com/celery/celery/issues/6153
140141
celery-4.4: Celery>=4.4,<4.5,!=4.4.4
142+
celery-5.0: Celery>=5.0,<5.1
141143

142144
requests: requests>=2.0
143145

0 commit comments

Comments
 (0)
0