8000 Fix ASV benchmark configuration issues; don't run benchmarks on non-m… · GeraldSoellinger/pvlib-python@a741799 · GitHub
[go: up one dir, main page]
Skip to content

Commit a741799

Browse files
kandersolarkandersolar
authored
Fix ASV benchmark configuration issues; don't run benchmarks on non-master fork branches (pvlib#1542)
* don't think we need the sed/tee stuff * better asv workflow job name * don't call setup.py for pvlib build * fiddling * fiddle * verbose * fiddle * clean up the mess * push: only trigger for master branch * tabs vs spaces...
1 parent e50def0 commit a741799

File tree

2 files changed

+13
-11
lines changed

2 files changed

+13
-11
lines changed

‎.github/workflows/asv_check.yml

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,15 @@
11
name: asv
22

33
# CI ASV CHECK is aimed to verify that the benchmarks execute without error.
4-
on: [pull_request, push]
4+
on:
5+
push:
6+
branches:
7+
- master
8+
pull_request:
9+
510

611
jobs:
7-
quick:
12+
quick-benchmarks:
813
runs-on: ubuntu-latest
914
defaults:
1015
run:
@@ -27,8 +32,4 @@ jobs:
2732
run: |
2833
cd benchmarks
2934
asv machine --yes
30-
asv run HEAD^! --quick --dry-run --show-stderr | sed "/failed$/ s/^/##[error]/" | tee benchmarks.log
31-
if grep "failed" benchmarks.log > /dev/null ; then
32-
exit 1
33-
fi
34-
35+
asv run HEAD^! --quick --dry-run --show-stderr

‎benchmarks/asv.conf.json

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,9 @@
2323
//
2424
// "install_command": ["in-dir={env_dir} python -mpip install {wheel_file}"],
2525
// "uninstall_command": ["return-code=any python -mpip uninstall -y {project}"],
26-
// "build_command": [
27-
// "python setup.py build",
28-
// "PIP_NO_BUILD_ISOLATION=false python -mpip wheel --no-deps --no-index -w {build_cache_dir} {build_dir}"
29-
// ],
26+
"build_command": [
27+
"python -m build -o {build_cache_dir}",
28+
],
3029

3130
// List of branches to benchmark. If not provided, defaults to "master"
3231
// (for git) or "default" (for mercurial).
@@ -115,6 +114,7 @@
115114
// minimum supported versions
116115
{
117116
"python": "3.7",
117+
"build": "",
118118
"numpy": "1.16.0",
119119
"pandas": "0.25.0",
120120
"scipy": "1.2.0",
@@ -126,6 +126,7 @@
126126
// latest versions available
127127
{
128128
"python": "3.8",
129+
"build": "",
129130
"numpy": "",
130131
"pandas": "",
131132
"scipy": "",

0 commit comments

Comments
 (0)
0