Merge pull request googleapis#382 from mahiuchun/dev

saicheems · web-flow · commit 395bb17d3538 · 2017-11-10T13:04:41.000-08:00
Log exception only when logging is enabled
diff --git a/google-http-client/src/main/java/com/google/api/client/http/HttpRequest.java b/google-http-client/src/main/java/com/google/api/client/http/HttpRequest.java
@@ -999,7 +999,9 @@ public HttpResponse execute() throws IOException {
         }
         // Save the exception in case the retries do not work and we need to re-throw it later.
         executeException = e;
-        logger.log(Level.WARNING, "exception thrown while executing request", e);
+        if (loggable) {
+          logger.log(Level.WARNING, "exception thrown while executing request", e);
+        }
       }
 
       // Flag used to indicate if an exception is thrown before the response has completed

Original file line number	Diff line number	Diff line change
`@@ -999,7 +999,9 @@ public HttpResponse execute() throws IOException {`
`999`	`999`	`}`
`1000`	`1000`	`// Save the exception in case the retries do not work and we need to re-throw it later.`
`1001`	`1001`	`executeException = e;`
`1002`		`- logger.log(Level.WARNING, "exception thrown while executing request", e);`
	`1002`	`+ if (loggable) {`
	`1003`	`+ logger.log(Level.WARNING, "exception thrown while executing request", e);`
	`1004`	`+ }`
`1003`	`1005`	`}`
`1004`	`1006`
`1005`	`1007`	`// Flag used to indicate if an exception is thrown before the response has completed`