fix: Handle the case when parameter.required is None and fix tests

hangfei · copybara-github · commit a7b4c9825352 · 2025-05-03T22:39:28.000-07:00
PiperOrigin-RevId: 754519323
diff --git a/src/google/adk/tools/openapi_tool/openapi_spec_parser/operation_parser.py b/src/google/adk/tools/openapi_tool/openapi_spec_parser/operation_parser.py
@@ -83,7 +83,8 @@ def _process_operation_parameters(self):
         schema.description = (
             description if not schema.description else schema.description
         )
-        required = param.required
+        # param.required can be None
+        required = param.required if param.required is not None else False
 
         self.params.append(
             ApiParameter(
diff --git a/tests/unittests/tools/openapi_tool/openapi_spec_parser/test_operation_parser.py b/tests/unittests/tools/openapi_tool/openapi_spec_parser/test_operation_parser.py
@@ -347,8 +347,8 @@ def test_get_json_schema(sample_operation):
   assert json_schema['type'] == 'object'
   assert 'param1' in json_schema['properties']
   assert 'prop1' in json_schema['properties']
-  assert 'param1' in json_schema['required']
-  assert 'prop1' in json_schema['required']
+  # By default nothing is required unless explicitly stated
+  assert 'required' not in json_schema or json_schema['required'] == []
 
 
 def test_get_signature_parameters(sample_operation):

Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,8 @@ def _process_operation_parameters(self):`
`83`	`83`	`schema.description = (`
`84`	`84`	`description if not schema.description else schema.description`
`85`	`85`	`)`
`86`		`- required = param.required`
	`86`	`+ # param.required can be None`
	`87`	`+ required = param.required if param.required is not None else False`
`87`	`88`
`88`	`89`	`self.params.append(`
`89`	`90`	`ApiParameter(`