tree: implemented recursive paths in __div__ and __getitem__ method, allowing the keys to contain slashes; adjusted test to check for this

Byron · Byron · commit d86e77edd500 · 2009-12-30T16:17:28.000+01:00
diff --git a/doc/tutorial.rst b/doc/tutorial.rst
@@ -239,13 +239,15 @@ query entries by name.
     'dir/file'
     >>> blob.abspath
     '/Users/mtrier/Development/git-python/dir/file'
+    >>>tree['dir/file'].sha == blob.sha
 
 There is a convenience method that allows you to get a named sub-object
 from a tree with a syntax similar to how paths are written in an unix
 system.
 
     >>> tree/"lib"
     <git.Tree "c1c7214dde86f76bc3e18806ac1f47c38b2b7a30">
+    >>> tree/"dir/file" == blob.sha
 
 You can also get a tree directly from the repository if you know its name.
 
diff --git a/lib/git/objects/tree.py b/lib/git/objects/tree.py
@@ -158,7 +158,32 @@ def __div__(self, file):
 		Raise 
 			KeyError if given file or tree does not exist in tree
 		"""
-		return self[file]
+		msg = "Blob or Tree named %r not found"
+		if '/' in file:
+			tree = self
+			item = self
+			tokens = file.split('/')
+			for i,token in enumerate(tokens):
+				item = tree[token]
+				if item.type == 'tree':
+					tree = item
+				else:
+					# safety assertion - blobs are at the end of the path
+					if i != len(tokens)-1:
+						raise KeyError(msg % file)  
+					return item
+				# END handle item type
+			# END for each token of split path
+			if item == self:
+				raise KeyError(msg % file)
+			return item
+		else:
+			for obj in self._cache:
+				if obj.name == file:
+					return obj
+			# END for each obj
+			raise KeyError( msg % file )
+		# END handle long paths
 
 
 	def __repr__(self):
@@ -205,11 +230,7 @@ def __getitem__(self,item):
 		
 		if isinstance(item, basestring):
 			# compatability
-			for obj in self._cache:
-				if obj.name == item:
-					return obj
-			# END for each obj
-			raise KeyError( "Blob or Tree named %s not found" % item )
+			return self.__div__(item)
 		# END index is basestring 
 		
 		raise TypeError( "Invalid index type: %r" % item )
diff --git a/test/git/test_tree.py b/test/git/test_tree.py
@@ -54,7 +54,10 @@ def test_traverse(self):
 			assert os.path.isabs(item.abspath)
 			if '/' in item.path:
 				found_slash = True
-				break
+			# END check for slash
+			
+			# slashes in paths are supported as well 
+			assert root[item.path] == item == root/item.path
 		# END for each item
 		assert found_slash
   
