vm.c: guard arguments [EXPERIMENTAL]

nobu · nobu · commit 7768312c1da6 · 2017-03-18T11:29:35.000Z
* vm.c (invoke_iseq_block_from_c): guard arguments on stack, not
  to be clobbered during splatting.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58012 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
diff --git a/vm.c b/vm.c
@@ -998,12 +998,14 @@ invoke_iseq_block_from_c(rb_thread_t *th, const struct rb_captured_block *captur
     th->passed_bmethod_me = NULL;
 
     CHECK_VM_STACK_OVERFLOW(cfp, argc);
+    cfp->sp = sp + i;
     for (i=0; i<argc; i++) {
 	sp[i] = argv[i];
     }
 
     opt_pc = vm_yield_setup_args(th, iseq, argc, sp, passed_block_handler,
 				 (type == VM_FRAME_MAGIC_LAMBDA ? (splattable ? arg_setup_lambda : arg_setup_method) : arg_setup_block));
+    cfp->sp = sp;
 
     if (me == NULL) {
 	return invoke_block(th, iseq, self, captured, cref, type, opt_pc);
diff --git a/vm_insnhelper.c b/vm_insnhelper.c
@@ -2506,7 +2506,11 @@ vm_callee_setup_block_arg_arg0_check(VALUE *argv)
 {
     VALUE ary, arg0 = argv[0];
     ary = rb_check_array_type(arg0);
+#if 0
     argv[0] = arg0;
+#else
+    VM_ASSERT(argv[0] == arg0);
+#endif
     return ary;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -2506,7 +2506,11 @@ vm_callee_setup_block_arg_arg0_check(VALUE *argv)`
`2506`	`2506`	`{`
`2507`	`2507`	`VALUE ary, arg0 = argv[0];`
`2508`	`2508`	`ary = rb_check_array_type(arg0);`
	`2509`	`+#if 0`
`2509`	`2510`	`argv[0] = arg0;`
	`2511`	`+#else`
	`2512`	`+ VM_ASSERT(argv[0] == arg0);`
	`2513`	`+#endif`
`2510`	`2514`	`return ary;`
`2511`	`2515`	`}`
`2512`	`2516`