Merge pull request #2370 from XWB/formfix

stof · web-flow · commit c0ba63245f41 · 2016-12-19T11:39:33.000+01:00
Call Form::isValid() with an unsubmitted form is deprecated
diff --git a/Controller/ChangePasswordController.php b/Controller/ChangePasswordController.php
@@ -65,7 +65,7 @@ public function changePasswordAction(Request $request)
 
         $form->handleRequest($request);
 
-        if ($form->isValid()) {
+        if ($form->isSubmitted() && $form->isValid()) {
             /** @var $userManager UserManagerInterface */
             $userManager = $this->get('fos_user.user_manager');
 
diff --git a/Controller/GroupController.php b/Controller/GroupController.php
@@ -91,7 +91,7 @@ public function editAction(Request $request, $groupName)
 
         $form->handleRequest($request);
 
-        if ($form->isValid()) {
+        if ($form->isSubmitted() && $form->isValid()) {
             /** @var $groupManager \FOS\UserBundle\Model\GroupManagerInterface */
             $groupManager = $this->get('fos_user.group_manager');
 
@@ -141,7 +141,7 @@ public function newAction(Request $request)
 
         $form->handleRequest($request);
 
-        if ($form->isValid()) {
+        if ($form->isSubmitted() && $form->isValid()) {
             $event = new FormEvent($form, $request);
             $dispatcher->dispatch(FOSUserEvents::GROUP_CREATE_SUCCESS, $event);
 
diff --git a/Controller/ProfileController.php b/Controller/ProfileController.php
@@ -79,7 +79,7 @@ public function editAction(Request $request)
 
         $form->handleRequest($request);
 
-        if ($form->isValid()) {
+        if ($form->isSubmitted() && $form->isValid()) {
             /** @var $userManager UserManagerInterface */
             $userManager = $this->get('fos_user.user_manager');
 
diff --git a/Controller/ResettingController.php b/Controller/ResettingController.php
@@ -161,7 +161,7 @@ public function resetAction(Request $request, $token)
 
         $form->handleRequest($request);
 
-        if ($form->isValid()) {
+        if ($form->isSubmitted() && $form->isValid()) {
             $event = new FormEvent($form, $request);
             $dispatcher->dispatch(FOSUserEvents::RESETTING_RESET_SUCCESS, $event);
 
