8000 Allow symfony/filesystem earlier than 4.4.17 · Issue #8 · FriendsOfPHP/proxy-manager-lts · GitHub
[go: up one dir, main page]
Skip to content

Allow symfony/filesystem earlier than 4.4.17 #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sp-jose-herrero opened this issue Feb 26, 2021 · 2 comments
Closed

Allow symfony/filesystem earlier than 4.4.17 #8

sp-jose-herrero opened this issue Feb 26, 2021 · 2 comments

Comments

@sp-jose-herrero
Copy link
sp-jose-herrero commented Feb 26, 2021 •
edited
Loading

Requirements have a dependency with an especific version of symfony/filesystem >= 4.4.17, this avoids installation if using earlier versions of Symfony.
I see this library is used just to dump code to disk, something that was present on earlier versions of symfony/filesystem, I have forked the project and tried symfony/filesystem:^3.4 to be exact 3.4.47 and it works fine, there is some reason to require '>= 4.4.17`?
@nicolas-grekas
Copy link
Collaborator

v4.4.17 contains symfony/symfony#39059, which is needed to pass a test in this repo.
If you're up to working on a way to skip this test when a previous version is installed, I'm open to a PR.
Note that 3.4 is EOLed, so that you'd better upgrade instead ;)

@nicolas-grekas
Copy link
Collaborator

Closing as explained, feel free to submit a PR if you'd like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nicolas-grekas @sp-jose-herrero
0