Limit feedback range to 0.1 - 0.9

relic-se · relic-se · commit e855e3e1bae5 · 2025-05-01T10:54:10.000-05:00
diff --git a/shared-bindings/audiofilters/Phaser.c b/shared-bindings/audiofilters/Phaser.c
@@ -145,7 +145,7 @@ MP_PROPERTY_GETSET(audiofilters_phaser_frequency_obj,
 
 
 //|     feedback: synthio.BlockInput
-//|     """The amount of which the incoming signal is fed back into the phasing filters from 0 to 1 where 0 is no feedback and 1 is full feedback."""
+//|     """The amount of which the incoming signal is fed back into the phasing filters from 0.1 to 0.9."""
 static mp_obj_t audiofilters_phaser_obj_get_feedback(mp_obj_t self_in) {
     return common_hal_audiofilters_phaser_get_feedback(self_in);
 }
diff --git a/shared-module/audiofilters/Phaser.c b/shared-module/audiofilters/Phaser.c
@@ -221,7 +221,7 @@ audioio_get_buffer_result_t audiofilters_phaser_get_buffer(audiofilters_phaser_o
             // get the effect values we need from the BlockInput. These may change at run time so you need to do bounds checking if required
             shared_bindings_synthio_lfo_tick(self->base.sample_rate, n / self->base.channel_count);
             mp_float_t frequency = synthio_block_slot_get_limited(&self->frequency, MICROPY_FLOAT_CONST(0.0), self->nyquist);
-            mp_float_t feedback = synthio_block_slot_get_limited(&self->feedback, MICROPY_FLOAT_CONST(0.0), MICROPY_FLOAT_CONST(1.0));
+            mp_float_t feedback = synthio_block_slot_get_limited(&self->feedback, MICROPY_FLOAT_CONST(0.1), MICROPY_FLOAT_CONST(0.9));
             mp_float_t mix = synthio_block_slot_get_limited(&self->mix, MICROPY_FLOAT_CONST(0.0), MICROPY_FLOAT_CONST(1.0));
 
             if (mix <= MICROPY_FLOAT_CONST(0.01)) { // if mix is zero pure sample only

Original file line number	Diff line number	Diff line change
`@@ -145,7 +145,7 @@ MP_PROPERTY_GETSET(audiofilters_phaser_frequency_obj,`
`145`	`145`
`146`	`146`
`147`	`147`	`//\| feedback: synthio.BlockInput`
`148`		`-//\| """The amount of which the incoming signal is fed back into the phasing filters from 0 to 1 where 0 is no feedback and 1 is full feedback."""`
	`148`	`+//\| """The amount of which the incoming signal is fed back into the phasing filters from 0.1 to 0.9."""`
`149`	`149`	`static mp_obj_t audiofilters_phaser_obj_get_feedback(mp_obj_t self_in) {`
`150`	`150`	`return common_hal_audiofilters_phaser_get_feedback(self_in);`
`151`	`151`	`}`