minor symfony#29726 [Lock] Fix lock test random failure (jderusse)

fabpot · fabpot · commit 1fafdaf9e6f9 · 2019-01-01T18:30:58.000+01:00
This PR was merged into the 3.4 branch. Discussion ---------- [Lock] Fix lock test random failure | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | NA The expiration of some store (PDO and Memcached) have a precision of 1 second. The current test suite of the component tries to putof the expiration to time + 1 second then tries to check the value of the lock. This could generate test failure (see https://travis-ci.org/symfony/symfony/jobs/473530213#L3389) Commits ------- 8cff565 Fix random test failure on lock
diff --git a/src/Symfony/Component/Lock/Tests/Store/ExpiringStoreTestTrait.php b/src/Symfony/Component/Lock/Tests/Store/ExpiringStoreTestTrait.php
@@ -47,10 +47,10 @@ public function testExpiration()
         $store = $this->getStore();
 
         $store->save($key);
-        $store->putOffExpiration($key, $clockDelay / 1000000);
+        $store->putOffExpiration($key, 2 * $clockDelay / 1000000);
         $this->assertTrue($store->exists($key));
 
-        usleep(2 * $clockDelay);
+        usleep(3 * $clockDelay);
         $this->assertFalse($store->exists($key));
     }
 
@@ -86,10 +86,10 @@ public function testRefreshLock()
         $store = $this->getStore();
 
         $store->save($key);
-        $store->putOffExpiration($key, $clockDelay / 1000000);
+        $store->putOffExpiration($key, 2 * $clockDelay / 1000000);
         $this->assertTrue($store->exists($key));
 
-        usleep(2 * $clockDelay);
+        usleep(3 * $clockDelay);
         $this->assertFalse($store->exists($key));
     }
 
