8000 OPTIM: remove memcopy for X_argsorted in GBRT models · Felixhawk/scikit-learn@3290453 · GitHub
[go: up one dir, main page]
Skip to content

Commit 3290453

Browse files
ogriselogrisel
committed
OPTIM: remove memcopy for X_argsorted in GBRT models
1 parent 7430eba commit 3290453

File tree

2 files changed

+29
-39
lines changed

2 files changed

+29
-39
lines changed

‎sklearn/tree/_tree.c

Lines changed: 28 additions & 38 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎sklearn/tree/_tree.pyx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1216,7 +1216,7 @@ cdef class PresortBestSplitter(Splitter):
12161216
if self.X_old != self.X:
12171217
self.X_old = self.X
12181218
self.X_argsorted = \
1219-
np.asfortranarray(np.argsort(X, axis=0).astype(np.int32))
1219+
np.asfortranarray(np.argsort(X, axis=0), dtype=np.int32)
12201220

12211221
self.X_argsorted_ptr = <INT32_t*>self.X_argsorted.data
12221222
self.X_argsorted_stride = <SIZE_t> self.X_argsorted.strides[1] / <SIZE_t> self.X_argsorted.itemsize

0 commit comments

Comments
 (0)
0