8000 tweak display of the github message (#14) · EuroPython/internal-bot@3512a27 · GitHub
[go: up one dir, main page]
Skip to content

Commit 3512a27

Browse files
artczartcz
authored
tweak display of the github message (#14)
1 parent d084ec0 commit 3512a27

File tree

3 files changed

+17
-9
lines changed

3 files changed

+17
-9
lines changed

‎intbot/core/integrations/github.py

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,14 @@ def get_repository(self): # pragma: no cover
130130
class GithubProjectV2Item(GithubWebhook):
131131
# NOTE: This might be something for pydantic schemas in the future
132132

133+
def short_action(self):
134+
# "projects_v2_item.edited" -> changed
135+
# "projects_v2_item.created" -> created
136+
action = self.action.split(".")[1]
137+
return {
138+
"edited": "changed",
139+
}.get(action, action)
140+
133141
@property
134142
def sender(self):
135143
sender = self.get_sender()
@@ -206,7 +214,7 @@ def as_discord_message(self) -> str:
206214
return message(
207215
**{
208216
"sender": self.sender,
209-
"action": self.action,
217+
"action": self.short_action(),
210218
"details": details,
211219
}
212220
)

‎intbot/tests/test_integrations/test_github.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ def test_parse_github_webhook_raises_value_error_for_unsupported():
2222

2323
def test_github_project_created_event():
2424
parser = GithubProjectV2Item(
25-
action="created",
25+
action="projects_v2_item.created",
2626
headers={},
2727
content={
2828
"sender": {"login": "testuser", "html_url": "https://github.com/testuser"},
@@ -52,7 +52,7 @@ def test_github_project_created_event():
5252

5353
def test_github_project_edited_event_for_status_change():
5454
parser = GithubProjectV2Item(
55-
action="changed",
55+
action="projects_v2_item.edited",
5656
headers={},
5757
content={
5858
"sender": {"login": "testuser", "html_url": "https://github.com/testuser"},
@@ -91,7 +91,7 @@ def test_github_project_edited_event_for_status_change():
9191

9292
def test_github_project_edited_event_for_date_change():
9393
parser = GithubProjectV2Item(
94-
action="edited",
94+
action="projects_v2_item.edited",
9595
headers={},
9696
content={
9797
"sender": {"login": "testuser", "html_url": "https://github.com/testuser"},
@@ -122,15 +122,15 @@ def test_github_project_edited_event_for_date_change():
122122
message = parser.as_discord_message()
123123

124124
assert message == (
125-
"[@testuser](https://github.com/testuser) edited **Deadline** of "
125+
"[@testuser](https://github.com/testuser) changed **Deadline** of "
126126
"**[Test Issue](https://github.com/test-issue)** "
127127
"from **2024-01-01** to **2025-01-05**"
128128
)
129129

130130

131131
def 10714 test_github_project_item_draft_issue_created():
132132
parser = GithubProjectV2Item(
133-
action="created",
133+
action="projects_v2_item.created",
134134
headers={},
135135
content={
136136
"sender": {"login": "testuser", "html_url": "https://github.com/testuser"},
@@ -153,7 +153,7 @@ def test_github_project_item_draft_issue_created():
153153

154154
def test_github_project_item_edited_event_no_changes():
155155
parser = GithubProjectV2Item(
156-
action="edited",
156+
action="projects_v2_item.edited",
157157
headers={},
158158
content={
159159
"sender": {"login": "testuser", "html_url": "https://github.com/testuser"},
@@ -173,7 +173,7 @@ def test_github_project_item_edited_event_no_changes():
173173
message = parser.as_discord_message()
174174

175175
assert message == (
176-
"[@testuser](https://github.com/testuser) edited "
176+
"[@testuser](https://github.com/testuser) changed "
177177
"[Test Issue](https://github.com/test-issue)"
178178
)
179179

‎intbot/tests/test_tasks.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ def test_process_github_webhook_creates_a_message_from_supported(
162162
assert dm.content == (
163163
"GitHub: [@github-project-automation[bot]]"
164164
"(https://github.com/apps/github-project-automation)"
165-
" projects_v2_item.edited **Status** of "
165+
" changed **Status** of "
166166
"**[Test Issue](https://github.com/test-issue)**"
167167
" from **Done** to **In progress**"
168168
)

0 commit comments

Comments
 (0)
0