Rollup merge of rust-lang#69491 - petrochenkov:symprint, r=Mark-Simulacrum

Dylan-DPC · web-flow · commit ffe4af57118b · 2020-02-28T01:55:42.000+01:00
rustc_span: Add `Symbol::to_ident_string` for use in diagnostic messages Covers the same error reporting use case (rust-lang#69387 (comment)) as the `Display` impl for `Ident`. cc rust-lang#69053 Follow-up to rust-lang#69387. r? @Mark-Simulacrum
diff --git a/src/librustc_span/symbol.rs b/src/librustc_span/symbol.rs
@@ -1023,6 +1023,14 @@ impl Symbol {
     pub fn as_u32(self) -> u32 {
         self.0.as_u32()
     }
+
+    /// This method is supposed to be used in error messages, so it's expected to be
+    /// identical to printing the original identifier token written in source code
+    /// (`token_to_string`, `Ident::to_string`), except that symbols don't keep the rawness flag
+    /// or edition, so we have to guess the rawness using the global edition.
+    pub fn to_ident_string(self) -> String {
+        Ident::with_dummy_span(self).to_string()
+    }
 }
 
 impl fmt::Debug for Symbol {

Original file line number	Diff line number	Diff line change
`@@ -1023,6 +1023,14 @@ impl Symbol {`
`1023`	`1023`	`pub fn as_u32(self) -> u32 {`
`1024`	`1024`	`self.0.as_u32()`
`1025`	`1025`	`}`
	`1026`	`+`
	`1027`	`+ /// This method is supposed to be used in error messages, so it's expected to be`
	`1028`	`+ /// identical to printing the original identifier token written in source code`
	`1029`	+ /// (`token_to_string`, `Ident::to_string`), except that symbols don't keep the rawness flag
	`1030`	`+ /// or edition, so we have to guess the rawness using the global edition.`
	`1031`	`+ pub fn to_ident_string(self) -> String {`
	`1032`	`+ Ident::with_dummy_span(self).to_string()`
	`1033`	`+ }`
`1026`	`1034`	`}`
`1027`	`1035`
`1028`	`1036`	`impl fmt::Debug for Symbol {`