MNT Fix CodeQL

DimitriPapadopoulos · Charlie-XIAO · web-flow · commit 76b2c95f8a4d · 2025-03-18T17:08:28.000+01:00
Inefficient regular expression

This part of the regular expression may cause exponential backtracking on strings starting with `.. |` and containing many repetitions of `A`.

Co-authored-by: Yao Xiao &lt;108576690+Charlie-XIAO@users.noreply.github.com&gt;
diff --git a/sklearn/tests/test_min_dependencies_readme.py b/sklearn/tests/test_min_dependencies_readme.py
@@ -34,6 +34,7 @@ def test_min_dependencies_readme():
     pattern = re.compile(
         r"(\.\. \|)"
         r"(([A-Za-z]+\-?)+)"
+        r"(([A-Za-z]+(?:-[A-Za-z]+)*)?)"
         r"(MinVersion\| replace::)"
         r"( [0-9]+\.[0-9]+(\.[0-9]+)?)"
     )

Original file line number	Diff line number	Diff line change
`@@ -34,6 +34,7 @@ def test_min_dependencies_readme():`
`34`	`34`	`pattern = re.compile(`
`35`	`35`	`r"(\.\. \\|)"`
`36`	`36`	`r"(([A-Za-z]+\-?)+)"`
	`37`	`+ r"(([A-Za-z]+(?:-[A-Za-z]+)*)?)"`
`37`	`38`	`r"(MinVersion\\| replace::)"`
`38`	`39`	`r"( [0-9]+\.[0-9]+(\.[0-9]+)?)"`
`39`	`40`	`)`