[FrameworkBundle] fixed _locale management in core.request

fabpot · fabpot · commit 8457bfa36548 · 2011-06-04T22:59:06.000+02:00
diff --git a/src/Symfony/Bundle/FrameworkBundle/EventListener/RouterListener.php b/src/Symfony/Bundle/FrameworkBundle/EventListener/RouterListener.php
@@ -61,10 +61,6 @@ public function onEarlyCoreRequest(GetResponseEvent $event)
             $request->isSecure() ? $request->getPort() : $this->httpsPort
         );
 
-        if ($session = $request->getSession()) {
-            $context->setParameter('_locale', $session->getLocale());
-        }
-
         $this->router->setContext($context);
     }
 
@@ -100,9 +96,17 @@ public function onCoreRequest(GetResponseEvent $event)
             throw new MethodNotAllowedHttpException($e->getAllowedMethods(), $message, $e);
         }
 
-        if (HttpKernelInterface::MASTER_REQUEST === $event->getRequestType() && $locale = $request->attributes->get('_locale')) {
-            $request->getSession()->setLocale($locale);
-            $this->router->getContext()->setParameter('_locale', $locale);
+        if (HttpKernelInterface::MASTER_REQUEST === $event->getRequestType()) {
+            $context = $this->router->getContext();
+            $session = $request->getSession();
+            if ($locale = $request->attributes->get('_locale')) {
+                if ($session) {
+                    $session->setLocale($locale);
+                }
+                $context->setParameter('_locale', $locale);
+            } elseif ($session) {
+                $context->setParameter('_locale', $session->getLocale());
+            }
         }
     }
 
