8000 🤖 Merge PR #69561 [lodash] Fix _.partial() with 3 arity func and full… · DefinitelyTyped/DefinitelyTyped@7fb3bcc · GitHub
[go: up one dir, main page]
Skip to content

Commit 7fb3bcc

Browse files
YuseiUenoYuseiUeno
authored
🤖 Merge PR #69561 [lodash] Fix _.partial() with 3 arity func and full args by @YuseiUeno 
1 parent ab5017e commit 7fb3bcc

File tree

2 files changed

+13
-2
lines changed

2 files changed

+13
-2
lines changed

‎types/lodash/common/function.d.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -655,7 +655,6 @@ declare module "../index" {
655655
<T1, T2, T3, T4, R>(func: Function4<T1, T2, T3, T4, R>, plc1: __, plc2: __, arg3: T3): Function3<T1, T2, T4, R>;
656656
<T1, T2, T3, T4, R>(func: Function4<T1, T2, T3, T4, R>, arg1: T1, plc2: __, arg3: T3): Function2<T2, T4, R>;
657657
<T1, T2, T3, T4, R>(func: Function4<T1, T2, T3, T4, R>, plc1: __, arg2: T2, arg3: T3): Function2<T1, T4, R>;
658-
<T1, T2, T3, T4, R>(func: Function4<T1, T2, T3, T4, R>, arg1: T1, arg2: T2, arg3: T3): Function1<T4, R>;
659658
<T1, T2, T3, T4, R>(func: Function4<T1, T2, T3, T4, R>, plc1: __, plc2: __, plc3: __, arg4: T4): Function3<T1, T2, T3, R>;
660659
<T1, T2, T3, T4, R>(func: Function4<T1, T2, T3, T4, R>, arg1: T1, plc2: __, plc3: __, arg4: T4): Function2<T2, T3, R>;
661660
<T1, T2, T3, T4, R>(func: Function4<T1, T2, T3, T4, R>, plc1: __, arg2: T2, plc3: __, arg4: T4): Function2<T1, T3, R>;

‎types/lodash/lodash-tests.ts

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7282,6 +7282,9 @@ _.templateSettings; // $ExpectType TemplateSettings
72827282
const func3 = (arg1: number, arg2: string, arg3: boolean): number => {
72837283
return arg1 * arg2.length + (arg3 ? 1 : 0);
72847284
};
7285+
const func4 = (arg1: number, arg2: string, arg3: boolean, arg4: number): number => {
7286+
return arg1 * arg2.length + (arg3 ? 1 : 0) - arg4;
7287+
}
72857288

72867289
// with arity 0 function
72877290
_.partial(func0); // $ExpectType () => number
@@ -7295,7 +7298,16 @@ _.templateSettings; // $ExpectType TemplateSettings
72957298
_.partial(func2, _.partial.placeholder, "foo"); // $ExpectType Function1<number, number>
72967299
_.partial(func2, 42, "foo"); // $ExpectType () => number
72977300
// with arity 3 function
7298-
_.partial(func3, 42, _, true);
7301+
_.partial(func3) // $ExpectType (arg1: number, arg2: string, arg3: boolean) => number
7302+
_.partial(func3, 42) // $ExpectType (arg2: string, arg3: boolean) => number
7303+
_.partial(func3, 42, _, true) // $ExpectType Function1<string, number>;
7304+
_.partial(func3, 42, "foo", true) // $ExpectType () => number
7305+
// with arity 4 function
7306+
_.partial(func4) // $ExpectType (arg1: number, arg2: string, arg3: boolean: arg4: number) => number
7307+
_.partial(func4, 42) // $ExpectType (arg2: string, arg3: boolean: arg4: number) => number
7308+
_.partial(func4, 42, _, true, 10) // $ExpectType Function1<string, number>;
7309+
_.partial(func4, _, _, _, 10) // $ExpectType Function3<number, string, boolean, number>;
7310+
_.partial(func4, 42, "foo", true, 10) // $ExpectType () => number
72997311

73007312
// with arity 0 function
73017313
_.partialRight(func0); // $ExpectType Function0<number>

0 commit comments

Comments
 (0)
0