minor symfony#21783 [DependencyInjection] remove dead code (hhamon)

nicolas-grekas · nicolas-grekas · commit 22968cda3bcc · 2017-02-27T16:31:05.000+01:00
This PR was merged into the 2.7 branch. Discussion ---------- [DependencyInjection] remove dead code | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | ~ This PR removes some dead code introduced 7 years ago (!!!) by a wrong merge :) Commits ------- 158b689 [DependencyInjection] removed dead code.
diff --git a/src/Symfony/Component/DependencyInjection/Tests/Dumper/PhpDumperTest.php b/src/Symfony/Component/DependencyInjection/Tests/Dumper/PhpDumperTest.php
@@ -34,13 +34,10 @@ public static function setUpBeforeClass()
 
     public function testDump()
     {
-        $dumper = new PhpDumper($container = new ContainerBuilder());
+        $dumper = new PhpDumper(new ContainerBuilder());
 
         $this->assertStringEqualsFile(self::$fixturesPath.'/php/services1.php', $dumper->dump(), '->dump() dumps an empty container as an empty PHP class');
         $this->assertStringEqualsFile(self::$fixturesPath.'/php/services1-1.php', $dumper->dump(array('class' => 'Container', 'base_class' => 'AbstractContainer', 'namespace' => 'Symfony\Component\DependencyInjection\Dump')), '->dump() takes a class and a base_class options');
-
-        $container = new ContainerBuilder();
-        new PhpDumper($container);
     }
 
     public function testDumpOptimizationString()

Original file line number	Diff line number	Diff line change
`@@ -34,13 +34,10 @@ public static function setUpBeforeClass()`
`34`	`34`
`35`	`35`	`public function testDump()`
`36`	`36`	`{`
`37`		`- $dumper = new PhpDumper($container = new ContainerBuilder());`
	`37`	`+ $dumper = new PhpDumper(new ContainerBuilder());`
`38`	`38`
`39`	`39`	`$this->assertStringEqualsFile(self::$fixturesPath.'/php/services1.php', $dumper->dump(), '->dump() dumps an empty container as an empty PHP class');`
`40`	`40`	`$this->assertStringEqualsFile(self::$fixturesPath.'/php/services1-1.php', $dumper->dump(array('class' => 'Container', 'base_class' => 'AbstractContainer', 'namespace' => 'Symfony\Component\DependencyInjection\Dump')), '->dump() takes a class and a base_class options');`
`41`		`-`
`42`		`- $container = new ContainerBuilder();`
`43`		`- new PhpDumper($container);`
`44`	`41`	`}`
`45`	`42`
`46`	`43`	`public function testDumpOptimizationString()`