Fixed is_upgrade. Provided a couple of tests.

trollfot · trollfot · commit 3dcd0c448041 · 2018-11-11T00:43:55.000+01:00
diff --git a/http_parser/parser.pyx b/http_parser/parser.pyx
@@ -354,7 +354,7 @@ cdef class HttpParser:
     def is_upgrade(self):
         """ Do we get upgrade header in the request. Useful for
         websockets """
-        return self._parser_upgrade
+        return self._parser.upgrade
 
     def is_headers_complete(self):
         """ return True if all headers have been parsed. """
diff --git a/testing/test_headers.py b/testing/test_headers.py
@@ -19,6 +19,22 @@ def test_repeated_continuation_header():
     hdr = HttpStream(stream).headers()
     assert hdr['X-Test'] == 'foo bar, baz qux'
 
+def test_upgrade_header():
+    stream = io.BytesIO(b'GET /test HTTP/1.1\r\nConnection: keep-alive, upgrade\r\nUpgrade: websocket\r\nSec-WebSocket-Key: hojIvDoHedBucveephosh8==\r\nSec-WebSocket-Version: 13\r\n\r\n')
+    hdr = HttpStream(stream)
+    hdr.headers()
+    assert hdr.parser.is_upgrade() == 1
+
+    stream = io.BytesIO(b'GET /test HTTP/1.1\r\nConnection: upgrade\r\nUpgrade: websocket\r\nSec-WebSocket-Key: hojIvDoHedBucveephosh8==\r\nSec-WebSocket-Version: 13\r\n\r\n')
+    hdr = HttpStream(stream)
+    hdr.headers()
+    assert hdr.parser.is_upgrade() == 1
+
+    stream = io.BytesIO(b'GET /test HTTP/1.1\r\nConnection: shenanigans\r\n\r\n')
+    hdr = HttpStream(stream)
+    hdr.headers()
+    assert hdr.parser.is_upgrade() == 0
+
 def test_continuation_header_py():
     stream = io.BytesIO(b'GET /test HTTP/1.1\r\nX-Test: foo\r\n bar\r\n\r\n')
     hdr = HttpStream(stream, parser_class=PyHttpParser).headers()
