Fix parsing metrics with decimal timestamp #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
698cce4 to
492f44f
Compare
duncanista
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When receiving metrics over dogstatsd, we receive metrics in the format:
metric.name:15|c|#env:dev|T1656581409, whereT1656581409is the timestamp.We parse the timestamp as
i64, which means that if the timestamp is a float such asT1656581409.123, the parse will fail, and we fallback tonow.Motivation
Just for flexibility. Even though metrics are rounded to the nearest 10 second bucket, we should still support decimal input.
E.g. v108 of datadog-lambda-python sends timestamped metrics with decimals. Therefore, we currently fallback to
nowsince the parse as u64 fails.Additional Notes
Describe how to test/QA your changes
I tested manually with local builds of Node+Extension, where Node was sending timestamps with a decimal:
arn:aws:lambda:us-east-1:<sandbox account>:layer:nhulston-datadog-extension:336And timestamped metrics now work as expected:
Also added a basic unit test