10000 [RUM][RWOL] Fix explanation on the error-based retention filters by MaelNamNam · Pull Request #28902 · DataDog/documentation · GitHub
[go: up one dir, main page]
Skip to content

[RUM][RWOL] Fix explanation on the error-based retention filters #28902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 23, 2025
Merged

[RUM][RWOL] Fix explanation on the error-based retention filters #28902

merged 6 commits into from
Apr 23, 2025

Conversation

MaelNamNam
Copy link
Contributor

What does this PR do? What is the motivation?

We're about to release RUM Without Limits (RWOL), this PR fixes a wrong message in one of our guides.

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

To have your PR automatically merged after it receives the required reviews, add the following PR comment:

/merge

Additional notes

@MaelNamNam MaelNamNam requested review from a team as code owners April 22, 2025 10:19
@github-actions github-actions bot added the Guide Content impacting a guide label Apr 22, 2025
@github-actions GitHub Actions
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

@MaelNamNam
Copy link
Contributor Author

/merge

@dd-devflow
Copy link
dd-devflow bot commented Apr 22, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-04-22 13:37:44 UTC ℹ️ Start processing command /merge

2025-04-22 13:37:47 UTC ❌ MergeQueue

This PR is rejected because it was updated

@maycmlee
Copy link
Contributor

/merge

@dd-devflow
Copy link
dd-devflow bot commented Apr 22, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-04-22 13:51:15 UTC ℹ️ Start processing command /merge

2025-04-22 13:51:22 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-04-22 17:52:06 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@rtrieu
Copy link
Contributor
rtrieu commented Apr 22, 2025

/merge

@dd-devflow
Copy link
dd-devflow bot commented Apr 22, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-04-22 18:53:23 UTC ℹ️ Start processing command /merge

2025-04-22 18:53:44 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-04-22 22:54:04 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@rtrieu
Copy link
Contributor
rtrieu commented Apr 23, 2025

/merge -c

@dd-devflow
Copy link
dd-devflow bot commented Apr 23, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-04-23 17:37:39 UTC ℹ️ Start processing command /merge -c
If you need support, contact us on Slack #devflow!

2025-04-23 17:37:40 UTC ❌ Devflow: /merge -c

This merge request was already processed and can't be unqueued anymore.

To get help about command usage, write /merge --help

If you need support, contact us on Slack #devflow with those details!

@rtrieu
Copy link
Contributor
rtrieu commented Apr 23, 2025

/merge

@dd-devflow
Copy link
dd-devflow bot commented Apr 23, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-04-23 19:53:42 UTC ℹ️ Start processing command /merge

2025-04-23 19:53:47 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-04-23 21:50:09 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in master is approximately 18m (p90).

2025-04-23 22:10:21 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 20f66d7 into master Apr 23, 2025
19 of 26 checks passed
@dd-mergequeue dd-mergequeue bot deleted the maelnamnam/rum/fix_retention_filters_use_cases branch April 23, 2025 22:10
estherk15 pushed a commit that referenced this pull request May 8, 2025
@MaelNamNam @rtrieu @estherk15
[RUM][RWOL] Fix explanation on the error-based retention filters (#28902
6562101 
)

Co-authored-by: rtrieu <107086888+rtrieu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxime-matheron maxime-matheron maxime-matheron approved these changes

@rtrieu rtrieu rtrieu approved these changes

Assignees
No one assigned
Labels
Guide Content impacting a guide mergequeue-status: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MaelNamNam @maycmlee @rtrieu @maxime-matheron
0