8000 Added datadog-ci span english section by CelianR · Pull Request #28128 · DataDog/documentation · GitHub
[go: up one dir, main page]
Skip to content

Added datadog-ci span english section #28128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Apr 24, 2025
Merged

Added datadog-ci span english section #28128

merged 12 commits into from
Apr 24, 2025

Conversation

CelianR
Copy link
Contributor
@CelianR CelianR commented Mar 13, 2025 •
edited
Loading

What does this PR do? What is the motivation?

Adds documentation about the datadog-ci span command added in this PR.

Merge instructions

  • Waiting for this PR to be merged and shipped

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

@CelianR CelianR self-assigned this Mar 13, 2025
@CelianR CelianR mentioned this pull request Mar 13, 2025
Merged
1 task
@github-actions GitHub Actions
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

@CelianR CelianR marked this pull request as ready for review March 14, 2025 08:34
@CelianR CelianR requested review from a team as code owners March 14, 2025 08:34
@CelianR CelianR requested a review from rodrigo-roca March 14, 2025 08:34
rodrigo-roca
rodrigo-roca reviewed Mar 24, 2025
View reviewed changes
Copy link
Contributor
@rodrigo-roca rodrigo-roca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments!

CelianR and others added 2 commits March 24, 2025 08:38
rodrigo-roca
rodrigo-roca approved these changes Mar 24, 2025
View reviewed changes
Copy link
Contributor
@rodrigo-roca rodrigo-roca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gturbat
Copy link
Contributor
gturbat commented Mar 24, 2025

My 2 cents: I think he structure of this page is becoming a bit unintuitive, I would:

  • Move Trace a command in GitHub Actions below Trace multiple commands -> Let's group together the "setup" parts
  • Rename Trace a command in GitHub Actions into Known issue with GitHub Actions -> Let's explicit it is about troubleshooting a specific issue
  • Rename Trace a command into Trace a command line
  • Rename Trace multiple commands into Trace a command block -> Let's make it explicit that this is not about batching a group of spans, but about creating a single span for a sequence of command lines

gturbat
gturbat reviewed Apr 11, 2025
View reviewed changes
urseberry
urseberry reviewed Apr 21, 2025
View reviewed changes
CelianR and others added 4 commits April 23, 2025 07:12
@CelianR @urseberry
Update content/en/continuous_integration/pipelines/custom_commands.md
1a86872 
Co-authored-by: Ursula Chen <58821586+urseberry@users.noreply.github.com>
@CelianR @urseberry
Update content/en/continuous_integration/pipelines/custom_commands.md
5fd458c 
Co-authored-by: Ursula Chen <58821586+urseberry@users.noreply.github.com>
@CelianR @urseberry
Update content/en/continuous_integration/pipelines/custom_commands.md
ae7f314 
Co-authored-by: Ursula Chen <58821586+urseberry@users.noreply.github.com>
@CelianR
Merge branch 'master' into celian/datadog-ci-span
2c158e6
@CelianR
Copy link
Contributor Author
CelianR commented Apr 23, 2025

/merge

@dd-devflow
Copy link
dd-devflow bot commented Apr 23, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-04-23 11:14:19 UTC ℹ️ Start processing command /merge

2025-04-23 11:14:24 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-04-23 15:15:08 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@buraizu
Copy link
Contributor
buraizu commented Apr 23, 2025

/merge

@dd-devflow
Copy link
dd-devflow bot commented Apr 23, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-04-23 23:44:02 UTC ℹ️ Start processing command /merge

2025-04-23 23:44:06 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 19m (p90).

2025-04-24 00:02:32 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 1e66785 into master Apr 24, 2025
22 of 23 checks passed
@dd-mergequeue dd-mergequeue bot deleted the celian/datadog-ci-span branch April 24, 2025 00:02
estherk15 pushed a commit that referenced this pull request May 8, 2025
@CelianR @rodrigo-roca
@urseberry @estherk15
Added datadog-ci span english section (#28128)
c395cb1 
* [datadog-ci-span] Updated english doc

* Update content/en/continuous_integration/pipelines/custom_commands.md

Co-authored-by: Rodrigo Roca <124577199+rodrigo-roca@users.noreply.github.com>

* [datadog-ci-span] Applied review suggestions

* [datadog-ci-span] Updated start / end /
6D40
 duration doc

* [datadog-ci-span] datadog-ci span -> datadog-ci trace span

* [datadog-ci-span] Applied suggestions

* [datadog-ci-span] Applied suggestions

* Update content/en/continuous_integration/pipelines/custom_commands.md

Co-authored-by: Ursula Chen <58821586+urseberry@users.noreply.github.com>

* Update content/en/continuous_integration/pipelines/custom_commands.md

Co-authored-by: Ursula Chen <58821586+urseberry@users.noreply.github.com>

* Update content/en/continuous_integration/pipelines/custom_commands.md

Co-authored-by: Ursula Chen <58821586+urseberry@users.noreply.github.com>

---------

Co-authored-by: Rodrigo Roca <124577199+rodrigo-roca@users.noreply.github.com>
Co-authored-by: Ursula Chen <58821586+urseberry@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urseberry urseberry urseberry approved these changes

@buraizu buraizu buraizu approved these changes

@gturbat gturbat gturbat approved these changes

@rodrigo-roca rodrigo-roca rodrigo-roca approved these changes

Assignees

@CelianR CelianR

Labels
mergequeue-status: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@CelianR @gturbat @buraizu @urseberry @rodrigo-roca
0