-
Notifications
You must be signed in to change notification settings - Fork 306
Alternative API Security sampling algorithm #8961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
this( | ||
DEFAULT_MAX_ITEM_COUNT, | ||
DEFAULT_INTERVAL_SECONDS, | ||
new Random().nextLong(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 14 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~ce506c980d, baseline=1.50.0-SNAPSHOT~089cf8fd47
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.03 s) : 0, 1030028
Total [baseline] (11.166 s) : 0, 11166012
Agent [candidate] (1.031 s) : 0, 1031367
Total [candidate] (11.282 s) : 0, 11281822
section appsec
Agent [baseline] (1.178 s) : 0, 1178385
Total [baseline] (11.294 s) : 0, 11294271
Agent [candidate] (1.173 s) : 0, 1173242
Total [candidate] (11.248 s) : 0, 11247891
section iast
Agent [baseline] (1.16 s) : 0, 1159817
Total [baseline] (11.365 s) : 0, 11364947
Agent [candidate] (1.151 s) : 0, 1151362
Total [candidate] (11.472 s) : 0, 11471584
section profiling
Agent [baseline] (1.266 s) : 0, 1266374
Total [baseline] (11.514 s) : 0, 11514405
Agent [candidate] (1.265 s) : 0, 1265128
Total [candidate] (11.453 s) : 0, 11453092
gantt
title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~ce506c980d, baseline=1.50.0-SNAPSHOT~089cf8fd47
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.898 ms) : 0, 687898
BytebuddyAgent [candidate] (689.404 ms) : 0, 689404
GlobalTracer [baseline] (242.013 ms) : 0, 242013
GlobalTracer [candidate] (242.195 ms) : 0, 242195
AppSec [baseline] (57.325 ms) : 0, 57325
AppSec [candidate] (57.758 ms) : 0, 57758
Debugger [baseline] (6.208 ms) : 0, 6208
Debugger [candidate] (6.19 ms) : 0, 6190
Remote Config [baseline] (724.439 µs) : 0, 724
Remote Config [candidate] (815.31 µs) : 0, 815
Telemetry [baseline] (12.127 ms) : 0, 12127
Telemetry [candidate] (11.281 ms) : 0, 11281
section appsec
BytebuddyAgent [baseline] (707.458 ms) : 0, 707458
BytebuddyAgent [candidate] (704.783 ms) : 0, 704783
GlobalTracer [baseline] (235.438 ms) : 0, 235438
GlobalTracer [candidate] (233.871 ms) : 0, 233871
IAST [baseline] (22.122 ms) : 0, 22122
IAST [candidate] (21.708 ms) : 0, 21708
AppSec [baseline] (176.025 ms) : 0, 176025
AppSec [candidate] (175.519 ms) : 0, 175519
Debugger [baseline] (5.917 ms) : 0, 5917
Debugger [candidate] (5.974 ms) : 0, 5974
Remote Config [baseline] (616
8000
.192 µs) : 0, 616
Remote Config [candidate] (611.665 µs) : 0, 612
Telemetry [baseline] (7.32 ms) : 0, 7320
Telemetry [candidate] (7.295 ms) : 0, 7295
section iast
BytebuddyAgent [baseline] (808.835 ms) : 0, 808835
BytebuddyAgent [candidate] (802.851 ms) : 0, 802851
GlobalTracer [baseline] (233.217 ms) : 0, 233217
GlobalTracer [candidate] (230.951 ms) : 0, 230951
IAST [baseline] (27.301 ms) : 0, 27301
IAST [candidate] (27.624 ms) : 0, 27624
AppSec [baseline] (52.479 ms) : 0, 52479
AppSec [candidate] (51.823 ms) : 0, 51823
Debugger [baseline] (5.921 ms) : 0, 5921
Debugger [candidate] (6.006 ms) : 0, 6006
Remote Config [baseline] (594.569 µs) : 0, 595
Remote Config [candidate] (596.334 µs) : 0, 596
Telemetry [baseline] (7.852 ms) : 0, 7852
Telemetry [candidate] (8.01 ms) : 0, 8010
section profiling
BytebuddyAgent [baseline] (675.291 ms) : 0, 675291
BytebuddyAgent [candidate] (675.937 ms) : 0, 675937
GlobalTracer [baseline] (360.323 ms) : 0, 360323
GlobalTracer [candidate] (360.287 ms) : 0, 360287
AppSec [baseline] (61.755 ms) : 0, 61755
AppSec [candidate] (61.073 ms) : 0, 61073
Debugger [baseline] (6.128 ms) : 0, 6128
Debugger [candidate] (6.017 ms) : 0, 6017
Remote Config [baseline] (648.716 µs) : 0, 649
Remote Config [candidate] (656.548 µs) : 0, 657
Telemetry [baseline] (8.127 ms) : 0, 8127
Telemetry [candidate] (8.083 ms) : 0, 8083
ProfilingAgent [baseline] (103.383 ms) : 0, 103383
ProfilingAgent [candidate] (102.396 ms) : 0, 102396
Profiling [baseline] (103.408 ms) : 0, 103408
Profiling [candidate] (102.421 ms) : 0, 102421
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~ce506c980d, baseline=1.50.0-SNAPSHOT~089cf8fd47
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.023 s) : 0, 1022969
Total [baseline] (8.529 s) : 0, 8529220
Agent [candidate] (1.024 s) : 0, 1024128
Total [candidate] (8.521 s) : 0, 8520507
section iast
Agent [baseline] (1.152 s) : 0, 1151734
Total [baseline] (9.208 s) : 0, 9208047
Agent [candidate] (1.15 s) : 0, 1150198
Total [candidate] (9.179 s) : 0, 9178737
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.15 s) : 0, 1150318
Total [baseline] (9.157 s) : 0, 9157047
Agent [candidate] (1.156 s) : 0, 1155918
Total [candidate] (9.144 s) : 0, 9143665
section iast_TELEMETRY_OFF
Agent [baseline] (1.147 s) : 0, 1147282
Total [baseline] (9.211 s) : 0, 9210608
Agent [candidate] (1.15 s) : 0, 1150262
Total [candidate] (9.19 s) : 0, 9189755
gantt
title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~ce506c980d, baseline=1.50.0-SNAPSHOT~089cf8fd47
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (684.059 ms) : 0, 684059
BytebuddyAgent [candidate] (684.068 ms) : 0, 684068
GlobalTracer [baseline] (240.406 ms) : 0, 240406
GlobalTracer [candidate] (240.925 ms) : 0, 240925
AppSec [baseline] (56.827 ms) : 0, 56827
AppSec [candidate] (58.1 ms) : 0, 58100
Debugger [baseline] (6.13 ms) : 0, 6130
Debugger [candidate] (6.202 ms) : 0, 6202
Remote Config [baseline] (729.769 µs) : 0, 730
Remote Config [candidate] (743.514 µs) : 0, 744
Telemetry [baseline] (11.186 ms) : 0, 11186
Telemetry [candidate] (10.444 ms) : 0, 10444
section iast
BytebuddyAgent [baseline] (803.687 ms) : 0, 803687
BytebuddyAgent [candidate] (801.865 ms) : 0, 801865
GlobalTracer [baseline] (231.086 ms) : 0, 231086
GlobalTracer [candidate] (231.372 ms) : 0, 231372
IAST [baseline] (26.766 ms) : 0, 26766
IAST [candidate] (25.341 ms) : 0, 25341
AppSec [baseline] (52.197 ms) : 0, 52197
AppSec [candidate] (53.593 ms) : 0, 53593
Debugger [baseline] (5.952 ms) : 0, 5952
Debugger [candidate] (5.986 ms) : 0, 5986
Remote Config [baseline] (596.622 µs) : 0, 597
Remote Config [candidate] (622.569 µs) : 0, 623
Telemetry [baseline] (7.855 ms) : 0, 7855
Telemetry [candidate] (7.929 ms) : 0, 7929
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (801.828 ms) : 0, 801828
BytebuddyAgent [candidate] (806.516 ms) : 0, 806516
GlobalTracer [baseline] (230.675 ms) : 0, 230675
GlobalTracer [candidate] (231.652 ms) : 0, 231652
IAST [baseline] (27.011 ms) : 0, 27011
IAST [candidate] (24.947 ms) : 0, 24947
AppSec [baseline] (52.773 ms) : 0, 52773
AppSec [candidate] (54.868 ms) : 0, 54868
Debugger [baseline] (5.987 ms) : 0, 5987
Debugger [candidate] (5.9 ms) : 0, 5900
Remote Config [baseline] (594.313 µs) : 0, 594
Remote Config [candidate] (588.934 µs) : 0, 589
Telemetry [baseline] (7.992 ms) : 0, 7992
Telemetry [candidate] (7.868 ms) : 0, 7868
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (798.976 ms) : 0, 798976
BytebuddyAgent [candidate] (801.612 ms) : 0, 801612
GlobalTracer [baseline] (231.002 ms) : 0, 231002
GlobalTracer [candidate] (231.29 ms) : 0, 231290
IAST [baseline] (26.665 ms) : 0, 26665
IAST [candidate] (28.957 ms) : 0, 28957
AppSec [baseline] (51.309 ms) : 0, 51309
AppSec [candidate] (50.335 ms) : 0, 50335
Debugger [baseline] (5.972 ms) : 0, 5972
Debugger [candidate] (6.026 ms) : 0, 6026
Remote Config [baseline] (590.384 µs) : 0, 590
Remote Config [candidate] (601.916 µs) : 0, 602
Telemetry [baseline] (7.78 ms) : 0, 7780
Telemetry [candidate] (7.849 ms) : 0, 7849
LoadParameters
See matching parameters
SummaryFound 7 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 14 unstable metrics.
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~ce506c980d, baseline=1.50.0-SNAPSHOT~089cf8fd47
dateFormat X
axisFormat %s
section baseline
no_agent (15.596 s) : 15596000, 15596000
. : milestone, 15596000,
appsec (14.877 s) : 14877000, 14877000
. : milestone, 14877000,
iast (18.987 s) : 18987000, 18987000
. : milestone, 18987000,
iast_GLOBAL (18.27 s) : 18270000, 18270000
. : milestone, 18270000,
profiling (15.214 s) : 15214000, 15214000
. : milestone, 15214000,
tracing (15.02 s) : 15020000, 15020000
. : milestone, 15020000,
section candidate
no_agent (15.344 s) : 15344000, 15344000
. : milestone, 15344000,
appsec (14.925 s) : 14925000, 14925000
. : milestone, 14925000,
iast (18.449 s) : 18449000, 18449000
. : milestone, 18449000,
iast_GLOBAL (18.311 s) : 18311000, 18311000
. : milestone, 18311000,
profiling (15.125 s) : 15125000, 15125000
. : milestone, 15125000,
tracing (14.809 s) : 14809000, 14809000
. : milestone, 14809000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~ce506c980d, baseline=1.50.0-SNAPSHOT~089cf8fd47
dateFormat X
axisFormat %s
section baseline
no_agent (1.478 ms) : 1466, 1489
. : milestone, 1478,
appsec (2.408 ms) : 2360, 2457
. : milestone, 2408,
iast (2.196 ms) : 2135, 2258
. : milestone, 2196,
iast_GLOBAL (2.246 ms) : 2184, 2308
. : milestone, 2246,
profiling (2.501 ms) : 2325, 2678
. : milestone, 2501,
tracing (2.01 ms) : 1962, 2057
. : milestone, 2010,
section candidate
no_agent (1.482 ms) : 1470, 1493
. : milestone, 1482,
appsec (2.408 ms) : 2359, 2457
. : milestone, 2408,
iast (2.197 ms) : 2135, 2258
. : milestone, 2197,
iast_GLOBAL (2.246 ms) : 2184, 2308
. : milestone, 2246,
profiling (2.041 ms) : 1991, 2090
. : milestone, 2041,
tracing (2.029 ms) : 1980, 2077
. : milestone, 2029,
|
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]