8000 Replace Integer.parseInt with character-check scan · DataDog/dd-trace-java@b69c69d · GitHub
[go: up one dir, main page]

Skip to content

Commit b69c69d

Browse files
committed
Replace Integer.parseInt with character-check scan
1 parent 419bb40 commit b69c69d

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

internal-api/src/main/java/datadog/trace/util/PidHelper.java

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -142,12 +142,15 @@ public static Set<String> getJavaPids() {
142142
// Hotspot,
143143
// but they are directories for J9.
144144
// This also makes sense as defensive programming.
145-
try {
146-
Integer.parseInt(name);
147-
return true;
148-
} catch (Exception e) {
145+
if (name.isEmpty()) {
149146
return false;
150147
}
148+
for (int i = 0; i < name.length(); i++) {
149+
if (!Character.isDigit(name.charAt(i))) {
150+
return false;
151+
}
152+
}
153+
return true;
151154
})
152155
.collect(Collectors.toSet());
153156
} catch (IOException e) {

0 commit comments

Comments
 (0)
0