Add support for isDefined in log template (#8859)

jpbempel · web-flow · commit 8fc90d53064e · 2025-05-21T16:53:27.000+02:00
Add isDefined as top level predicate for log template values
diff --git a/dd-java-agent/agent-debugger/debugger-el/src/main/java/com/datadog/debugger/el/JsonToExpressionConverter.java b/dd-java-agent/agent-debugger/debugger-el/src/main/java/com/datadog/debugger/el/JsonToExpressionConverter.java
@@ -50,7 +50,8 @@ public class JsonToExpressionConverter {
               "endsWith",
               "contains",
               "matches",
-              "instanceof"));
+              "instanceof",
+              "isDefined"));
 
   @FunctionalInterface
   interface BinaryPredicateExpressionFunction<T extends Expression> {
diff --git a/dd-java-agent/agent-debugger/debugger-el/src/test/resources/test_one_liner_value_expr_01.txt b/dd-java-agent/agent-debugger/debugger-el/src/test/resources/test_one_liner_value_expr_01.txt
@@ -19,3 +19,4 @@
 {"dsl": "", "json": {"contains": [{"ref": "str"}, "ll"]}}
 {"dsl": "", "json": {"matches": [{"ref": "str"}, "[helo]+"]}}
 {"dsl": "", "json": {"instanceof": [{"ref": "str"}, "java.lang.String"]}}
+{"dsl": "", "json": {"isDefined": {"ref": "str"}}}
diff --git a/dd-java-agent/agent-debugger/debugger-el/src/test/resources/test_value_expr_01.json b/dd-java-agent/agent-debugger/debugger-el/src/test/resources/test_value_expr_01.json
@@ -24,7 +24,8 @@
           {"endsWith": [{"ref": "str"}, "llo"]},
           {"contains": [{"ref": "str"}, "ll"]},
           {"matches": [{"ref": "str"}, "[helo]+"]},
-          {"instanceof": [{"ref": "str"}, "java.lang.String"]}
+          {"instanceof": [{"ref": "str"}, "java.lang.String"]},
+          {"isDefined": {"ref": "str"}}
         ]
       }
     ]

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,8 @@`
`24`	`24`	`{"endsWith": [{"ref": "str"}, "llo"]},`
`25`	`25`	`{"contains": [{"ref": "str"}, "ll"]},`
`26`	`26`	`{"matches": [{"ref": "str"}, "[helo]+"]},`
`27`		`- {"instanceof": [{"ref": "str"}, "java.lang.String"]}`
	`27`	`+ {"instanceof": [{"ref": "str"}, "java.lang.String"]},`
	`28`	`+ {"isDefined": {"ref": "str"}}`
`28`	`29`	`]`
`29`	`30`	`}`
`30`	`31`	`]`