10000 get test status from span · DataDog/dd-trace-java@3268b48 · GitHub
[go: up one dir, main page]

Skip to content

Commit 3268b48

Browse files
get test status from span
1 parent 97e4285 commit 3268b48

File tree

2 files changed

+5
-11
lines changed

2 files changed

+5
-11
lines changed

dd-java-agent/agent-ci-visibility/src/main/java/datadog/trace/civisibility/domain/TestImpl.java

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,6 @@ public class TestImpl implements DDTest {
6868
private final TestContext context;
6969
private final TestIdentifier identifier;
7070
private final long startMicros;
71-
private TestStatus status;
7271

7372
public TestImpl(
7473
AgentSpanContext moduleSpanContext,
@@ -138,7 +137,6 @@ public TestImpl(
138137
span.setTag(Tags.TEST_MODULE_ID, moduleSpanContext.getSpanId());
139138
span.setTag(Tags.TEST_SESSION_ID, moduleSpanContext.getTraceId());
140139

141-
status = TestStatus.pass;
142140
span.setTag(Tags.TEST_STATUS, TestStatus.pass);
143141

144142
if (testClass != null && !testClass.getName().equals(testSuiteName)) {
@@ -210,10 +208,6 @@ public TestIdentifier getIdentifier() {
210208
return identifier;
211209
}
212210

213-
public boolean hasFailed() {
214-
return span.isError();
215-
}
216-
217211
@Override
218212
public void setTag(String key, Object value) {
219213
span.setTag(key, value);
@@ -223,14 +217,11 @@ public void setTag(String key, Object value) {
223217
public void setErrorInfo(Throwable error) {
224218
span.setError(true);
225219
span.addThrowable(error);
226-
status = TestStatus.fail;
227220
span.setTag(Tags.TEST_STATUS, TestStatus.fail);
228221
}
229222

230223
@Override
231224
public void setSkipReason(String skipReason) {
232-
status = TestStatus.skip;
233-
234225
span.setTag(Tags.TEST_STATUS, TestStatus.skip);
235226
if (skipReason != null) {
236227
span.setTag(Tags.TEST_SKIP_REASON, skipReason);
@@ -244,7 +235,7 @@ public void setSkipReason(String skipReason) {
244235
}
245236

246237
public TestStatus getStatus() {
247-
return status;
238+
return (TestStatus) span.getTag(Tags.TEST_STATUS);
248239
}
249240

250241
public long getDuration(@Nullable Long endMicros) {

dd-java-agent/agent-ci-visibility/src/main/java/datadog/trace/civisibility/events/TestEventsHandlerImpl.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
import datadog.trace.api.civisibility.events.TestEventsHandler;
1111
import datadog.trace.api.civisibility.execution.TestExecutionHistory;
1212
import datadog.trace.api.civisibility.execution.TestExecutionPolicy;
13+
import datadog.trace.api.civisibility.execution.TestStatus;
1314
import datadog.trace.api.civisibility.telemetry.CiVisibilityCountMetric;
1415
import datadog.trace.api.civisibility.telemetry.CiVisibilityMetricCollector;
1516
import datadog.trace.api.civisibility.telemetry.tag.EventType;
@@ -255,7 +256,9 @@ public void onTestFinish(
255256

256257
TestIdentifier thisTest = test.getIdentifier();
257258
if (testExecutionHistory != null) {
258-
testExecutionHistory.registerExecution(test.getStatus(), test.getDuration(endTime));
259+
TestStatus testStatus = test.getStatus();
260+
testExecutionHistory.registerExecution(
261+
testStatus != null ? testStatus : TestStatus.skip, test.getDuration(endTime));
259262

260263
if (testExecutionHistory.hasFailedAllRetries()) {
261264
test.setTag(Tags.TEST_HAS_FAILED_ALL_RETRIES, true);

0 commit comments

Comments
 (0)
0