Protect for null lambda response types. (#551)

purple4reina · web-flow · commit 9c025c987118 · 2024-06-03T10:19:50.000-07:00
diff --git a/src/index.spec.ts b/src/index.spec.ts
@@ -449,6 +449,23 @@ describe("datadog", () => {
     expect(mockedIncrementInvocations).toBeCalledWith(expect.anything(), mockContext);
   });
 
+  it("doesn't increment batch item failures if its null", async () => {
+    const lambdaResponse: any = null;
+
+    const wrapped = datadog(async () => {
+      return lambdaResponse;
+    });
+
+    const lambdaResult = await wrapped({}, mockContext, () => {});
+
+    expect(lambdaResult).toEqual(lambdaResponse);
+
+    expect(mockedIncrementBatchItemFailures).toBeCalledTimes(0);
+    expect(mockedIncrementInvocations).toBeCalledTimes(1);
+
+    expect(mockedIncrementInvocations).toBeCalledWith(expect.anything(), mockContext);
+  });
+
   it("doesn't increment errors or invocations with config false setting", async () => {
     const handlerError: Handler = (event, context, callback) => {
       throw Error("Some error");
diff --git a/src/utils/batch-item-failures.ts b/src/utils/batch-item-failures.ts
@@ -1,6 +1,7 @@
 export function isBatchItemFailure(lambdaResponse: any): boolean {
   return (
     typeof lambdaResponse === "object" &&
+    lambdaResponse !== null &&
     "batchItemFailures" in lambdaResponse &&
     Array.isArray(lambdaResponse.batchItemFailures)
   );
