BLD: Fix code checking for old GCC on cygwin.

DWesl · DWesl · commit d9c21bbffe17 · 2020-07-09T12:45:08.000-04:00
I forgot the function returned bytes, not str.
I also accidentally passed an extra argument.
diff --git a/setup.py b/setup.py
@@ -258,7 +258,7 @@ def _gcc_version_less_than(obj, test_version):
                     [cc, "-dumpversion"],
                     stdout=subprocess.PIPE,
                 )
-                ver = LooseVersion(out.stdout.strip())
+                ver = LooseVersion(out.stdout.strip().decode("ascii"))
                 gcc_version_lt_provided = ver < test_version
         return gcc_version_lt_provided
 
@@ -291,7 +291,7 @@ def build_extension(self, ext):
             if _is_using_gcc(self):
                 if '-std=c99' not in ext.extra_compile_args:
                     ext.extra_compile_args.append('-std=c99')
-            if _is_old_gcc_on_cygwin(self, ext):
+            if _is_old_gcc_on_cygwin(self):
                 if '-ffixed-xmm' not in ext.extra_compile_args:
                     ext.extra_compile_args.append(
                         '-fno-asynchronous-unwind-tables '
