BLD: Fix flags added to compiler line for old GCC on MS.

DWesl · DWesl · commit 6ffbcb2e0df3 · 2020-07-09T12:45:08.000-04:00
It may be worth broadening the platform list, since I believe the
error this tries to fix is in the MS ABI/CRT rather than in the Cygwin
runtime.
diff --git a/setup.py b/setup.py
@@ -276,13 +276,8 @@ def build_a_library(self, build_info, lib_name, libraries):
                 build_info['extra_compiler_args'] = args
             if _is_old_gcc_on_cygwin(self):
                 args = build_info.get('extra_compiler_args') or []
-                args.append(
-                    '-fno-asynchronous-unwind-tables '
-                    '-ffixed-xmm16 -ffixed-xmm17 -ffixed-xmm18 -ffixed-xmm19 '
-                    '-ffixed-xmm20 -ffixed-xmm21 -ffixed-xmm22 -ffixed-xmm23 '
-                    '-ffixed-xmm24 -ffixed-xmm25 -ffixed-xmm26 -ffixed-xmm27 '
-                    '-ffixed-xmm28 -ffixed-xmm29 -ffixed-xmm30 -ffixed-xmm31'
-                )
+                args.append('-fno-asynchronous-unwind-tables')
+                args.extend('-ffixed-xmm{0:02d}'.format(i) for i in range(16, 32))
                 build_info['extra_compiler_args'] = args
             build_clib.build_a_library(self, build_info, lib_name, libraries)
 
@@ -293,13 +288,8 @@ def build_extension(self, ext):
                     ext.extra_compile_args.append('-std=c99')
             if _is_old_gcc_on_cygwin(self):
                 if '-ffixed-xmm' not in ext.extra_compile_args:
-                    ext.extra_compile_args.append(
-                        '-fno-asynchronous-unwind-tables '
-                        '-ffixed-xmm16 -ffixed-xmm17 -ffixed-xmm18 -ffixed-xmm19 '
-                        '-ffixed-xmm20 -ffixed-xmm21 -ffixed-xmm22 -ffixed-xmm23 '
-                        '-ffixed-xmm24 -ffixed-xmm25 -ffixed-xmm26 -ffixed-xmm27 '
-                        '-ffixed-xmm28 -ffixed-xmm29 -ffixed-xmm30 -ffixed-xmm31'
-                    )
+                    ext.extra_compile_args.append('-fno-asynchronous-unwind-tables')
+                    ext.extra_compile_args.extend('-ffixed-xmm{0:02d}'.format(i) for i in range(16, 32))
             build_ext.build_extension(self, ext)
     return new_build_clib, new_build_ext
 
