8000 feat: Move leetcode commands into submenu (#712) · DGGua/vscode-leetcode@45ae245 · GitHub
[go: up one dir, main page]
Skip to content
Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 45ae245

Browse files
jdneojdneo
authored
feat: Move leetcode commands into submenu (LeetCode-OpenSource#712)
1 parent ce92866 commit 45ae245

File tree

4 files changed

+19
-9
lines changed

4 files changed

+19
-9
lines changed

‎package-lock.json

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎package.json

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"license": "MIT",
99
"icon": "resources/LeetCode.png",
1010
"engines": {
11-
"vscode": "^1.42.0"
11+
"vscode": "^1.50.0"
1212
},
1313
"repository": {
1414
"type": "git",
@@ -243,6 +243,11 @@
243243
}
244244
],
245245
"editor/context": [
246+
{
247+
"submenu": "leetcode.editorAction"
248+
}
249+
],
250+
"leetcode.editorAction": [
246251
{
247252
"command": "leetcode.testSolution",
248253
"group": "leetcode@1"
@@ -261,6 +266,12 @@
261266
}
262267
]
263268
},
269+
"submenus": [
270+
{
271+
"id": "leetcode.editorAction",
272+
"label": "LeetCode"
273+
}
274+
],
264275
"configuration": [
265276
{
266277
"title": "LeetCode",
@@ -678,7 +689,7 @@
678689
"@types/mocha": "^2.2.42",
679690
"@types/node": "^14.14.33",
680691
"@types/require-from-string": "^1.2.0",
681-
"@types/vscode": "1.42.0",
692+
"@types/vscode": "1.50.0",
682693
"tslint": "^5.20.1",
683694
"typescript": "^4.3.2"
684695
},

‎src/explorer/LeetCodeTreeDataProvider.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ export class LeetCodeTreeDataProvider implements vscode.TreeDataProvider<LeetCod
2323

2424
public async refresh(): Promise<void> {
2525
await explorerNodeManager.refreshCache();
26-
this.onDidChangeTreeDataEvent.fire();
26+
this.onDidChangeTreeDataEvent.fire(null);
2727
}
2828

2929
public getTreeItem(element: LeetCodeNode): vscode.TreeItem | Thenable<vscode.TreeItem> {

‎src/utils/workspaceUtils.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,8 @@ export async function selectWorkspaceFolder(): Promise<string> {
1818
return workspaceFolderSetting;
1919
}
2020
}
21-
const workspaceFolders: vscode.WorkspaceFolder[] = vscode.workspace.workspaceFolders || [];
2221
let needAsk: boolean = true;
23-
for (const folder of workspaceFolders) {
22+
for (const folder of vscode.workspace.workspaceFolders || []) {
2423
if (isSubFolder(folder.uri.fsPath, workspaceFolderSetting)) {
2524
needAsk = false;
2625
}
@@ -47,7 +46,7 @@ export async function selectWorkspaceFolder(): Promise<string> {
4746
await vscode.commands.executeCommand("vscode.openFolder", vscode.Uri.file(workspaceFolderSetting), true);
4847
return "";
4948
case OpenOption.addToWorkspace:
50-
vscode.workspace.updateWorkspaceFolders(workspaceFolders.length, 0, { uri: vscode.Uri.file(workspaceFolderSetting) });
49+
vscode.workspace.updateWorkspaceFolders(vscode.workspace.workspaceFolders?.length ?? 0, 0, { uri: vscode.Uri.file(workspaceFolderSetting) });
5150
break;
5251
default:
5352
return "";

0 commit comments

Comments
 (0)
0