8000 Addressing PR feedback · CyberSys/firebase-admin-python@e542f91 · GitHub
[go: up one dir, main page]

Skip to content

Commit e542f91

Browse files
committed
Addressing PR feedback
1 parent b5b3dce commit e542f91

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

firebase_admin/multi_factor_config_mgt.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ class MultiFactorServerConfig:
4444
def __init__(self, data):
4545
if not isinstance(data, dict):
4646
raise ValueError(
47-
'Invalid data argument in MultiFactorServerConfig constructor: {0}'.format(data))
47+
'Invalid data argument in MultiFactorServerConfig constructor: {0}, must be a valid dict'.format(data))
4848
self._data = data
4949

5050
@property
@@ -120,7 +120,7 @@ def validate(self):
120120
# pylint: disable=C0123
121121
if type(self.adjacent_intervals) is not int:
122122
raise ValueError(
123-
'totp_provider_config.adjacent_intervals must be an integer between'
123+
'TOTPProviderConfig.adjacent_intervals must be an integer between'
124124
' 1 and 10 (inclusive).')
125125
if not 1 <= self.adjacent_intervals <= 10:
126126
raise ValueError(
@@ -167,16 +167,16 @@ def validate(self):
167167
'totp_provider_config'},
168168
config_name='ProviderConfig')
169169
if self.state is None:
170-
raise ValueError('provider_config.state must be defined.')
170+
raise ValueError('ProviderConfig.state must be defined.')
171171
if not isinstance(self.state, ProviderConfig.State):
172172
raise ValueError(
173-
'provider_config.state must be of type ProviderConfig.State.')
173+
'ProviderConfig.state must be of type ProviderConfig.State.')
174174
if self.totp_provider_config is None:
175175
raise ValueError(
176-
'provider_config.totp_provider_config must be defined.')
176+
'ProviderConfig.totp_provider_config must be defined.')
177177
if not isinstance(self.totp_provider_config, TOTPProviderConfig):
178178
raise ValueError(
179-
'provider_configs.totp_provider_config must be of type TOTPProviderConfig.')
179+
'ProviderConfig.totp_provider_config must be of type TOTPProviderConfig.')
180180

181181
def build_server_request(self):
182182
self.validate()

firebase_admin/project_config_mgt.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535

3636

3737
def get_project_config(app=None):
38-
"""Gets the project config corresponding to the given project_id.
38+
"""Gets the project config corresponding to the current project_id.
3939
4040
Args:
4141
app: An App instance (optional).

0 commit comments

Comments
 (0)
0