8000 [Android] Return an error if createDataChannel failed. · Condelab/flutter-webrtc@d2e7bb1 · GitHub
[go: up one dir, main page]

Skip to content

Commit d2e7bb1

Browse files
committed
[Android] Return an error if createDataChannel failed.
1 parent 9318d1f commit d2e7bb1

File tree

1 file changed

+10
-3
lines changed

1 file changed

+10
-3
lines changed

android/src/main/java/com/cloudwebrtc/webrtc/PeerConnectionObserver.java

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -133,12 +133,19 @@ void createDataChannel(String label, ConstraintsMap config, Result result) {
133133
// longer support them (in the face of multiple reported issues of
134134
// breakages).
135135
int dataChannelId = init.id;
136-
if (-1 != dataChannelId) {
136+
if (dataChannel != null && -1 != dataChannelId) {
137137
dataChannels.put(dataChannelId, dataChannel);
138138
registerDataChannelObserver(dataChannelId, dataChannel);
139-
}
140139

141-
result.success(null);
140+
ConstraintsMap params = new ConstraintsMap();
141+
params.putInt("id", dataChannel.id());
142+
params.putString("label", dataChannel.label());
143+
result.success(params.toMap());
144+
}else{
145+
result.error("createDataChannel",
146+
"Can't create data-channel for id: " + dataChannelId,
147+
null);
148+
}
142149
}
143150

144151
void dataChannelClose(int dataChannelId) {

0 commit comments

Comments
 (0)
0