8000 Add Adventure support for chat color arguments · Issue #469 · CommandAPI/CommandAPI · GitHub
[go: up one dir, main page]

Skip to content

Add Adventure support for chat color arguments #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
8000
JorelAli opened this issue Jul 4, 2023 · 3 comments
Closed

Add Adventure support for chat color arguments #469

JorelAli opened this issue Jul 4, 2023 · 3 comments
Labels
enhancement New feature or request implemented for next release This has been implemented in the current dev build for the next public release

Comments

@JorelAli
Copy link
Member
JorelAli commented Jul 4, 2023

Description

The CommandAPI should offer an AdventureChatColorArgument to return NamedTextColor objects instead of ChatColor

Expected code

NamedTextColor color = arguments.get(...)

Extra details

From this Discord discussion: https://discord.com/channels/745416925924032523/745757702608912556/1125919177094471730

@JorelAli JorelAli added the enhancement New feature or request label Jul 4, 2023
JorelAli added a commit that referenced this issue Jul 5, 2023
@JorelAli
Copy link
Member Author

Feature has been implemented on dev/dev. You can now use the AdventureChatColorArgument to get a NamedTextColor object representing the chat colour provided to you. Because Minecraft's colours support the base 16 colours and reset, but Adventure doesn't have a "colour" for reset, we treat reset as white.

Documentation is still required.

@JorelAli JorelAli added scheduled for next release This will be implemented for the next public release implemented for next release This has been implemented in the current dev build for the next public release and removed scheduled for next release This will be implemented for the next public release labels Jul 16, 2023
@JorelAli
Copy link
Member Author

Implemented for the next release.

@JorelAli
Copy link
Member Author

Implemented in 9.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request implemented for next release This has been implemented in the current dev build for the next public release
Projects
None yet
Development

No branches or pull requests

1 participant
0