Address some SonarCloud code smells on argument-exceptions2

willkroboth · willkroboth · commit 73b2d122ed05 · 2023-07-31T15:57:17.000-04:00
Remove obsolete unused type parameter T from InitialParseExceptionParser

Change test classes to default package visibility
diff --git a/commandapi-core/src/main/java/dev/jorel/commandapi/arguments/ExceptionHandlingArgumentType.java b/commandapi-core/src/main/java/dev/jorel/commandapi/arguments/ExceptionHandlingArgumentType.java
@@ -37,7 +37,7 @@ public record ExceptionHandlingArgumentType<T, ExceptionInformation>(
 		 * @param exceptionParser A function that parses the information in a {@link CommandSyntaxException} to create an
 		 * {@link ExceptionInformation} object.
 		 */
-		InitialParseExceptionParser<T, ExceptionInformation> exceptionParser
+		InitialParseExceptionParser<ExceptionInformation> exceptionParser
 ) implements ArgumentType<T> {
 
     @Override
diff --git a/commandapi-core/src/main/java/dev/jorel/commandapi/arguments/InitialParseExceptionParser.java b/commandapi-core/src/main/java/dev/jorel/commandapi/arguments/InitialParseExceptionParser.java
@@ -8,11 +8,10 @@
  * Extracts information about an exception that was thrown when an {@link ArgumentType} fails to parse.
  * See {@link InitialParseExceptionArgument#parseInitialParseException(CommandSyntaxException, StringReader)}.
  *
- * @param <T> The object returned when the wrapped {@link ArgumentType} is parsed.
  * @param <ExceptionInformation> The class that holds information about the exception.
  */
 @FunctionalInterface
-public interface InitialParseExceptionParser<T, ExceptionInformation> {
+public interface InitialParseExceptionParser<ExceptionInformation> {
     /**
      * Extracts information about an exception that was thrown when an {@link ArgumentType} fails to parse.
      * See {@link InitialParseExceptionArgument#parseInitialParseException(CommandSyntaxException, StringReader)}.
diff --git a/commandapi-platforms/commandapi-bukkit/commandapi-bukkit-test/commandapi-bukkit-test-tests/src/test/java/dev/jorel/commandapi/test/ArgumentParseExceptionArgumentTest.java b/commandapi-platforms/commandapi-bukkit/commandapi-bukkit-test/commandapi-bukkit-test-tests/src/test/java/dev/jorel/commandapi/test/ArgumentParseExceptionArgumentTest.java
@@ -12,7 +12,7 @@
 import java.util.Collection;
 import java.util.List;
 
-public class ArgumentParseExceptionArgumentTest extends TestBase {
+class ArgumentParseExceptionArgumentTest extends TestBase {
 
     /*********
      * Setup *
diff --git a/commandapi-platforms/commandapi-bukkit/commandapi-bukkit-test/commandapi-bukkit-test-tests/src/test/java/dev/jorel/commandapi/test/InitialParseExceptionArgumentTest.java b/commandapi-platforms/commandapi-bukkit/commandapi-bukkit-test/commandapi-bukkit-test-tests/src/test/java/dev/jorel/commandapi/test/InitialParseExceptionArgumentTest.java
@@ -10,7 +10,7 @@
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 
-public class InitialParseExceptionArgumentTest extends TestBase {
+class InitialParseExceptionArgumentTest extends TestBase {
 
 	/*********
 	 * Setup *
