[Bugfix] Fix replacing a nullable to-one on resource object

lindyhopchris · lindyhopchris · commit c083d163f69e · 2018-11-01T16:12:31.000Z
diff --git a/src/Document/ResourceObject.php b/src/Document/ResourceObject.php
@@ -683,10 +683,10 @@ private function putAttr(string $field, $value): self
 
     /**
      * @param string $field
-     * @param array $value
+     * @param array|null $value
      * @return ResourceObject
      */
-    private function putRelation(string $field, array $value): self
+    private function putRelation(string $field, ?array $value): self
     {
         $copy = clone $this;
         $copy->relationships[$field] = $copy->relationships[$field] ?? [];
diff --git a/tests/lib/Unit/Document/ResourceObjectTest.php b/tests/lib/Unit/Document/ResourceObjectTest.php
@@ -288,7 +288,29 @@ public function testReplaceAttribute(): void
         $this->assertSame($expected, $actual->toArray());
     }
 
-    public function testReplaceRelationship(): void
+    public function testReplaceToOne(): void
+    {
+        $author = ['type' => 'users', 'id' => '999'];
+
+        $expected = $this->values;
+        $expected['relationships']['author']['data'] = $author;
+
+        $this->assertNotSame($this->resource, $actual = $this->resource->replace('author', $author));
+        $this->assertSame($this->values, $this->resource->toArray(), 'original resource is not modified');
+        $this->assertSame($expected, $actual->toArray());
+    }
+
+    public function testReplaceToOneNull(): void
+    {
+        $expected = $this->values;
+        $expected['relationships']['author']['data'] = null;
+
+        $this->assertNotSame($this->resource, $actual = $this->resource->replace('author', null));
+        $this->assertSame($this->values, $this->resource->toArray(), 'original resource is not modified');
+        $this->assertSame($expected, $actual->toArray());
+    }
+
+    public function testReplaceToMany(): void
     {
         $comments = [
             ['type' => 'comments', 'id' => '123456'],
