[Tests] Improve sorted search test

lindyhopchris · lindyhopchris · commit 84a96e5b5c2b · 2017-09-08T09:55:17.000+01:00
diff --git a/src/Store/EloquentAdapter.php b/src/Store/EloquentAdapter.php
@@ -192,7 +192,7 @@ protected function newQuery()
      * @param Builder $query
      * @param Collection $includePaths
      *      the paths for resources that will be included.
-     * @return array
+     * @return void
      */
     protected function with(Builder $query, Collection $includePaths)
     {
diff --git a/tests/Integration/Eloquent/PostsTest.php b/tests/Integration/Eloquent/PostsTest.php
@@ -13,11 +13,25 @@ class PostsTest extends TestCase
      */
     protected $resourceType = 'posts';
 
-    public function testSearch()
+    /**
+     * Test searching with a sort parameter.
+     */
+    public function testSortedSearch()
     {
-        factory(Post::class, 3)->create();
+        $a = factory(Post::class)->create([
+            'title' => 'Title A',
+        ]);
+
+        $b = factory(Post::class)->create([
+            'title' => 'Title B',
+        ]);
+
+        $response = $this->doSearch(['sort' => '-title']);
+        $response->assertSearchResponse()->assertContainsOnly(['posts' => [$a->getKey(), $b->getKey()]]);
 
-        $this->doSearch(['sort' => '-created-at'])->assertSearchResponse();
+        $json = $response->decodeResponseJson();
+        $actual = [array_get($json, 'data.0.id'), array_get($json, 'data.1.id')];
+        $this->assertEquals([$b->getKey(), $a->getKey()], $actual);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -192,7 +192,7 @@ protected function newQuery()`
`192`	`192`	`* @param Builder $query`
`193`	`193`	`* @param Collection $includePaths`
`194`	`194`	`* the paths for resources that will be included.`
`195`		`- * @return array`
	`195`	`+ * @return void`
`196`	`196`	`*/`
`197`	`197`	`protected function with(Builder $query, Collection $includePaths)`
`198`	`198`	`{`