Add tests for helper method for marking a created resource

lindyhopchris · lindyhopchris · commit 47d5f6aabe99 · 2018-11-20T12:15:11.000Z
diff --git a/src/Queue/ClientDispatchable.php b/src/Queue/ClientDispatchable.php
@@ -65,7 +65,7 @@ public function resourceId(): ?string
     }
 
     /**
-     * Set the resource that the job relates to.
+     * Set the resource that was created by the job.
      *
      * If a job is creating a new resource, this method can be used to update
      * the client job with the created resource. This method does nothing if the
@@ -74,7 +74,7 @@ public function resourceId(): ?string
      * @param $resource
      * @return void
      */
-    public function setResource($resource): void
+    public function didCreate($resource): void
     {
         if ($this->wasClientDispatched()) {
             $this->clientJob->setResource($resource)->save();
diff --git a/tests/lib/Integration/Queue/QueueEventsTest.php b/tests/lib/Integration/Queue/QueueEventsTest.php
@@ -5,6 +5,7 @@
 use Carbon\Carbon;
 use CloudCreativity\LaravelJsonApi\Queue\ClientJob;
 use CloudCreativity\LaravelJsonApi\Tests\Integration\TestCase;
+use DummyApp\Download;
 
 class QueueEventsTest extends TestCase
 {
@@ -31,6 +32,10 @@ public function testCompletes()
             'completed_at' => Carbon::now()->format('Y-m-d H:i:s'),
             'failed' => false,
         ]);
+
+        $clientJob = $job->clientJob->refresh();
+
+        $this->assertInstanceOf(Download::class, $clientJob->getResource());
     }
 
     public function testFails()
diff --git a/tests/lib/Integration/Queue/TestJob.php b/tests/lib/Integration/Queue/TestJob.php
@@ -3,6 +3,7 @@
 namespace CloudCreativity\LaravelJsonApi\Tests\Integration\Queue;
 
 use CloudCreativity\LaravelJsonApi\Queue\ClientDispatchable;
+use DummyApp\Download;
 use Illuminate\Bus\Queueable;
 use Illuminate\Contracts\Queue\ShouldQueue;
 use Illuminate\Foundation\Bus\Dispatchable;
@@ -29,12 +30,20 @@ class TestJob implements ShouldQueue
     public $tries = 2;
 
     /**
+     * Execute the job.
+     *
+     * @return Download
      * @throws \Exception
      */
-    public function handle(): void
+    public function handle(): Download
     {
         if ($this->ex) {
             throw new \LogicException('Boom.');
         }
+
+        $download = factory(Download::class)->create();
+        $this->didCreate($download);
+
+        return $download;
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,7 @@ public function resourceId(): ?string`
`65`	`65`	`}`
`66`	`66`
`67`	`67`	`/**`
`68`		`- * Set the resource that the job relates to.`
	`68`	`+ * Set the resource that was created by the job.`
`69`	`69`	`*`
`70`	`70`	`* If a job is creating a new resource, this method can be used to update`
`71`	`71`	`* the client job with the created resource. This method does nothing if the`
`@@ -74,7 +74,7 @@ public function resourceId(): ?string`
`74`	`74`	`* @param $resource`
`75`	`75`	`* @return void`
`76`	`76`	`*/`
`77`		`- public function setResource($resource): void`
	`77`	`+ public function didCreate($resource): void`
`78`	`78`	`{`
`79`	`79`	`if ($this->wasClientDispatched()) {`
`80`	`80`	`$this->clientJob->setResource($resource)->save();`