py38 compat

MarcoGorelli · MarcoGorelli · commit ba09922d3c81 · 2024-11-28T16:47:29.000Z
diff --git a/packages/python/plotly/plotly/tests/test_optional/test_px/test_px_functions.py b/packages/python/plotly/plotly/tests/test_optional/test_px/test_px_functions.py
@@ -571,16 +571,15 @@ def test_timeline(constructor):
         ["Finish"],
     ],
 )
-def test_timeline_cols_already_temporal(constructor, datetime_columns: list[str]):
+def test_timeline_cols_already_temporal(constructor, datetime_columns):
     # https://github.com/plotly/plotly.py/issues/4913
     data = {
         "Task": ["Job A", "Job B", "Job C"],
         "Start": ["2009-01-01", "2009-03-05", "2009-02-20"],
         "Finish": ["2009-02-28", "2009-04-15", "2009-05-30"],
     }
-    df = constructor(data)
     df = (
-        nw.from_native(df)
+        nw.from_native(constructor(data))
         .with_columns(nw.col(datetime_columns).str.to_datetime(format="%Y-%m-%d"))
         .to_native()
     )

Original file line number	Diff line number	Diff line change
`@@ -571,16 +571,15 @@ def test_timeline(constructor):`
`571`	`571`	`["Finish"],`
`572`	`572`	`],`
`573`	`573`	`)`
`574`		`-def test_timeline_cols_already_temporal(constructor, datetime_columns: list[str]):`
	`574`	`+def test_timeline_cols_already_temporal(constructor, datetime_columns):`
`575`	`575`	`# https://github.com/plotly/plotly.py/issues/4913`
`576`	`576`	`data = {`
`577`	`577`	`"Task": ["Job A", "Job B", "Job C"],`
`578`	`578`	`"Start": ["2009-01-01", "2009-03-05", "2009-02-20"],`
`579`	`579`	`"Finish": ["2009-02-28", "2009-04-15", "2009-05-30"],`
`580`	`580`	`}`
`581`		`- df = constructor(data)`
`582`	`581`	`df = (`
`583`		`- nw.from_native(df)`
	`582`	`+ nw.from_native(constructor(data))`
`584`	`583`	`.with_columns(nw.col(datetime_columns).str.to_datetime(format="%Y-%m-%d"))`
`585`	`584`	`.to_native()`
`586`	`585`	`)`