FIX makedirs(..., exists_ok) not available in Python 2 (scikit-learn#9284)

SebastinSanty · ogrisel · commit cf67fa43d324 · 2017-07-06T16:30:17.000+02:00
diff --git a/sklearn/datasets/covtype.py b/sklearn/datasets/covtype.py
@@ -89,7 +89,8 @@ def fetch_covtype(data_home=None, download_if_missing=True,
     available = exists(samples_path)
 
     if download_if_missing and not available:
-        makedirs(covtype_dir, exist_ok=True)
+        if not exists(covtype_dir):
+            makedirs(covtype_dir)
         logger.warning("Downloading %s" % URL)
         f = BytesIO(urlopen(URL).read())
         Xy = np.genfromtxt(GzipFile(fileobj=f), delimiter=',')
diff --git a/sklearn/datasets/rcv1.py b/sklearn/datasets/rcv1.py
@@ -114,7 +114,8 @@ def fetch_rcv1(data_home=None, subset='all', download_if_missing=True,
     data_home = get_data_home(data_home=data_home)
     rcv1_dir = join(data_home, "RCV1")
     if download_if_missing:
-        makedirs(rcv1_dir, exist_ok=True)
+        if not exists(rcv1_dir):
+            makedirs(rcv1_dir)
 
     samples_path = _pkl_filepath(rcv1_dir, "samples.pkl")
     sample_id_path = _pkl_filepath(rcv1_dir, "sample_id.pkl")

Original file line number	Diff line number	Diff line change
`@@ -89,7 +89,8 @@ def fetch_covtype(data_home=None, download_if_missing=True,`
`89`	`89`	`available = exists(samples_path)`
`90`	`90`
`91`	`91`	`if download_if_missing and not available:`
`92`		`- makedirs(covtype_dir, exist_ok=True)`
	`92`	`+ if not exists(covtype_dir):`
	`93`	`+ makedirs(covtype_dir)`
`93`	`94`	`logger.warning("Downloading %s" % URL)`
`94`	`95`	`f = BytesIO(urlopen(URL).read())`
`95`	`96`	`Xy = np.genfromtxt(GzipFile(fileobj=f), delimiter=',')`