10000 Merge changes from 4.1 branch to 5.0 by Naktibalda · Pull Request #6221 · Codeception/Codeception · GitHub
[go: up one dir, main page]

Skip to content

Merge changes from 4.1 branch to 5.0 #6221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Jun 6, 2021
Merged

Merge changes from 4.1 branch to 5.0 #6221

merged 20 commits into from
Jun 6, 2021

Conversation

Naktibalda
Copy link
Member

No description provided.

ThomasLandauer and others added 18 commits March 16, 2021 14:15
Standardize "@example.com" as domain in documentation
The Cept format has been deprecated some 4 years ago #3976 - so I think it's about time to start thinking about ways to actually remove it from the codebase :-)
I deleted the explanation in order to remove the commands from https://codeception.com/docs/reference/Commands.html
Explaining `--debug` as alias for `-vv`
* Removing Cept

* Update GenerateScenarios.php
Action generator: Don't generate nullable types for PHP 7.0
Sounds like a tongue twister ... ;-)

I was expecting this text to be in https://github.com/Codeception/lib-innerbrowser/blob/master/src/Codeception/Lib/InnerBrowser.php#L941 - while in fact it's even in another module! So, again, a link at each function to get to its source code would really be nice - see #6063 (comment)
(More precisely: If the documentation isn't where the function is, then *two* links)
…ith-symfony-5.3

Make dry-run command compatible with symfony/console 5.3
* Add workaround for #1485 - don't attempt to read cookies while an alert is open

* Only apply workaround when module is WebDriver
@Naktibalda Naktibalda requested a review from TavoNiievez May 29, 2021 20:09
@TavoNiievez
Copy link
Member

btw, what does it take to completely remove the Cept format?
As I understood in Codeception 5 this deprecation would be effective.

@Naktibalda
Copy link
Member Author

Delete src/Codeception/Test/Cept.php, src/Codeception/Test/Loader/Cept.php and GenerateCept command.

@TavoNiievez
Copy link
Member

Well... no idea why it keeps failing :)

@Naktibalda Naktibalda force-pushed the 5.0-merge-4.1 branch 2 times, most recently from 00bdf0e to d10e28a Compare June 6, 2021 15:26
@TavoNiievez
Copy link
Member

GuzzleHttp\Psr7\Uri implements the magic method __toString()...
maybe mergeUrls should remove string typing in method signature and cast (string) internally.

@Naktibalda
Copy link
Member Author

One day we will be able to use stringable typehint.

@Naktibalda
Copy link
Member Author

string typehint can come back,
you removed casting to string in https://github.com/Codeception/module-phpbrowser/pull/12/files#diff-7089ef726bcb6e8e53ee0dc3317f15ff81fb7a999ae214323435a29f46c19649L175
so I raised Codeception/module-phpbrowser#14 to put it back.

@TavoNiievez
Copy link
Member

ahh ok, no problem

@TavoNiievez TavoNiievez self-requested a review June 6, 2021 17:04
@Naktibalda Naktibalda merged commit 51ef9bf into 5.0 Jun 6, 2021
@Naktibalda Naktibalda deleted the 5.0-merge-4.1 branch June 6, 2021 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0