Wrong argument name in Organization.create_team()

Alexander Alexandrov · aalexandrov · commit 5baf57a913b4 · 2014-04-29T11:06:25.000+02:00
Currently 'permissions', according to the API docs[1] should be 'permission'. [1] https://developer.github.com/v3/orgs/teams/#create-team
diff --git a/github3/orgs.py b/github3/orgs.py
@@ -303,14 +303,14 @@ def conceal_member(self, login):
         return self._boolean(self._delete(url), 204, 404)
 
     @requires_auth
-    def create_team(self, name, repo_names=[], permissions=''):
+    def create_team(self, name, repo_names=[], permission=''):
         """Assuming the authenticated user owns this organization,
         create and return a new team.
 
         :param str name: (required), name to be given to the team
         :param list repo_names: (optional) repositories, e.g.
             ['github/dotfiles']
-        :param str permissions: (optional), options:
+        :param str permission: (optional), options:
 
             - ``pull`` -- (default) members can not push or administer
                 repositories accessible by this team
@@ -322,7 +322,7 @@ def create_team(self, name, repo_names=[], permissions=''):
         :returns: :class:`Team <Team>`
         """
         data = {'name': name, 'repo_names': repo_names,
-                'permissions': permissions}
+                'permission': permission}
         url = self._build_url('teams', base_url=self._api)
         json = self._json(self._post(url, data), 201)
         return Team(json, self._session) if json else None
diff --git a/tests/test_orgs.py b/tests/test_orgs.py
@@ -214,15 +214,15 @@ def test_create_team(self):
             'data': {
                 'name': 'team',
                 'repo_names': [],
-                'permissions': 'push'
+                'permission': 'push'
             }
         }
 
         self.assertRaises(github3.GitHubError, self.org.create_team, None)
 
         self.not_called()
         self.login()
-        assert isinstance(self.org.create_team('team', permissions='push'),
+        assert isinstance(self.org.create_team('team', permission='push'),
                           github3.orgs.Team)
         self.mock_assertions()
 
