Merge pull request #147 from davide84/master

blink1073 · web-flow · commit 12a504146be0 · 2020-11-02T12:56:49.000-06:00
FIX: issue #146 (No output in Matlab 2020b)
diff --git a/matlab_kernel/kernel.py b/matlab_kernel/kernel.py
@@ -83,6 +83,14 @@ def _matlab(self):
             self.__matlab = matlab.engine.start_matlab()
         except matlab.engine.EngineError:
             self.__matlab = matlab.engine.connect_matlab()
+        # detecting the correct kwargs for async running
+        # matlab 'async' param is deprecated since it became a keyword in python 3.7
+        # instead, 'background' param is available and recommended since Matlab R2017b
+        self._async_kwargs = {'nargout': 0, 'async': True}
+        try:
+            self._matlab.eval('version', **self._async_kwargs)
+        except SyntaxError:
+            self._async_kwargs = {'nargout': 0, 'background': True}
         self._validated_plot_settings = {
             "backend": "inline",
             "size": (560, 420),
@@ -253,8 +261,7 @@ def _execute_async(self, code):
         try:
             with pipes(stdout=_PseudoStream(partial(self.Print, end="")),
                 stderr=_PseudoStream(partial(self.Error, end=""))):
-                kwargs = { 'nargout': 0, 'async': True }
-                future = self._matlab.eval(code, **kwargs)
+                future = self._matlab.eval(code, **self._async_kwargs)
                 future.result()
         except (SyntaxError, MatlabExecutionError, KeyboardInterrupt) as exc:
             pass
