Open Recent: if sketch was read only and it was saved, saved version was not put into recent sketches list. Fixed

Federico Fissore · Federico Fissore · commit 35d3aeb6d66b · 2015-06-11T17:36:02.000+02:00
diff --git a/app/src/processing/app/Base.java b/app/src/processing/app/Base.java
@@ -617,6 +617,12 @@ protected void storeRecentSketches(Sketch sketch) {
     PreferencesData.setCollection("recent.sketches", sketches);
   }
 
+  protected void removeRecentSketchPath(String path) {
+    Collection<String> sketches = new LinkedList<String>(PreferencesData.getCollection("recent.sketches"));
+    sketches.remove(path);
+    PreferencesData.setCollection("recent.sketches", sketches);
+  }
+
   // Because of variations in native windowing systems, no guarantees about
   // changes to the focused and active Windows can be made. Developers must
   // never assume that this Window is the focused or active Window until this
diff --git a/app/src/processing/app/Editor.java b/app/src/processing/app/Editor.java
@@ -2239,11 +2239,19 @@ private boolean handleSave2() {
     statusNotice(_("Saving..."));
     boolean saved = false;
     try {
+      boolean wasReadOnly = sketch.isReadOnly();
+      String previousMainFilePath = sketch.getMainFilePath();
       saved = sketch.save();
-      if (saved)
+      if (saved) {
         statusNotice(_("Done Saving."));
-      else
+        if (wasReadOnly) {
+          base.removeRecentSketchPath(previousMainFilePath);
+        }
+        base.storeRecentSketches(sketch);
+        base.rebuildRecentSketchesMenuItems();
+      } else {
         statusEmpty();
+      }
       // rebuild sketch menu in case a save-as was forced
       // Disabling this for 0125, instead rebuild the menu inside
       // the Save As method of the Sketch object, since that's the
