10000 Fix symfony dependency issues · BackEndTea/infection@dfc4cd0 · GitHub
[go: up one dir, main page]
Skip to content

Commit dfc4cd0

Browse files
BackEndTeaBackEndTea
BackEndTea
authored and
BackEndTea
committed
Fix symfony dependency issues
* Yaml::parseFile() wasn't present untill 3.4 > use parse() with file_get_contents() * Process didn't accept array untill 3.3 > Update to 3.3+ as 4.0+ needs array * Console had a bug issue in with empty defaults prior to 3.3.^ & 3.2.13 See: symfony/symfony#22244 > Update minimum to 3.13 and add a conflict rune for between 3.3.0 and 3.3.5 Be sure to test against lowest versions on travis.
1 parent 67cccdd commit dfc4cd0

File tree

5 files changed

+132
-190
lines changed

5 files changed

+132
-190
lines changed

‎.travis.yml

Lines changed: 6 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -35,22 +35,12 @@ jobs:
3535
stage: Test
3636
php: 7.1
3737
install:
38-
- composer install
39-
- |
40-
if [ "${SYMFONY_VERSION}" != "" ]; then
41-
composer config --unset platform
42-
composer require \
43-
symfony/console:${SYMFONY_VERSION} \
44-
symfony/filesystem:${SYMFONY_VERSION} \
45-
symfony/process:${SYMFONY_VERSION} \
46-
symfony/finder:${SYMFONY_VERSION} \
47-
symfony/yaml:${SYMFONY_VERSION}
48-
fi
38+
- if [ "$DEPS" == "LOW" ]; then composer update --prefer-lowest; else composer install; fi
4939
script:
5040
- if [[ $PHPDBG != 1 ]]; then xdebug-enable; fi
5141
- if [[ $PHPDBG != 1 ]]; then $PHPUNIT_BIN; else phpdbg -qrr $PHPUNIT_BIN; fi
5242
- |
53-
if [[ "${SYMFONY_VERSION}" != "" ]]; then
43+
if [[ "$DEPS" == "LOW" ]]; then
5444
./tests/e2e_tests bin/infection;
5545
else
5646
make build/bin/infection.phar;
@@ -80,12 +70,12 @@ jobs:
8070
-
8171
<<: *STANDARD_TEST_JOB
8272
php: 7.1
83-
env: SYMFONY_VERSION="^4.0"
73+
env: DEPS="LOW"
8474

8575
-
8676
<<: *STANDARD_TEST_JOB
8777
php: 7.1
88-
env: SYMFONY_VERSION="^4.0" PHPDBG=1
78+
env: DEPS="LOW" PHPDBG=1
8979

9080
-
9181
<<: *STANDARD_TEST_JOB
@@ -104,12 +94,12 @@ jobs:
10494
-
10595
<<: *STANDARD_TEST_JOB
10696
php: 7.1
107-
env: SYMFONY_VERSION="^4.0"
97+
env: DEPS="LOW"
10898

10999
-
110100
<<: *STANDARD_TEST_JOB
111101
php: 7.2
112-
env: SYMFONY_VERSION="^4.0" PHPDBG=1
102+
env: DEPS="LOW" PHPDBG=1
113103

114104
-
115105
<<: *STANDARD_TEST_JOB

‎composer.json

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -49,15 +49,16 @@
4949
},
5050
"config": {
5151
"platform": {
52-
"php": "7.1"
52+
"php": "7.1.3"
5353
},
5454
"sort-packages": true
5555
},
5656
"conflict": {
57-
"symfony/process": "3.4.2"
57+
"symfony/process": "3.4.2",
58+
"symfony/console": ">=3.3.0, <=3.3.5"
5859
},
5960
"require": {
60-
"php": "^7.1",
61+
"php": "^7.1.3",
6162
"ext-dom": "*",
6263
"ext-json": "*",
6364
"composer/xdebug-handler": "^1.3",
@@ -66,16 +67,16 @@
6667
"padraic/phar-updater": "^1.0.4",
6768
"pimple/pimple": "^3.2",
6869
"sebastian/diff": "^1.4 || ^2.0 || ^3.0",
69-
"symfony/console": "^3.2 || ^4.0",
70+
"symfony/console": "^3.2.13 || ^4.0",
7071
"symfony/filesystem": "^3.2 || ^4.0",
7172
"symfony/finder": "^3.2 || ^4.0",
72-
"symfony/process": "^3.2 || ^4.0",
73+
"symfony/process": "^3.3|| ^4.0",
7374
"symfony/yaml": "^3.2 || ^4.0",
7475
"webmozart/assert": "^1.3"
7576
},
7677
"require-dev": {
7778
"mockery/mockery": "^1.1",
78-
"phpunit/phpunit": "^6"
79+
"phpunit/phpunit": "^6.5"
7980
},
8081
"bin": ["bin/infection"]
8182
}

0 commit comments

Comments
 (0)
0