8000 Additional properties and XML detection is flawed · Issue #207 · Azure/msrest-for-python · GitHub
[go: up one dir, main page]
Skip to content

Additional properties and XML detection is flawed #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
lmazuel opened this issue Jun 1, 2020 · 0 comments
Open

Additional properties and XML detection is flawed #207

lmazuel opened this issue Jun 1, 2020 · 0 comments
Labels
enhancement

Comments

@lmazuel
Copy link
Member
lmazuel commented Jun 1, 2020

To build the additional properties set, we need to know what was consumed by the extractors to build the final object. What was NOT consumed, will go to the additional property bag.

We don't have a nice way to know what was consumed today, so we guessed it by introspecting the model built so far. This works ok for JSON, since this is simple key matching, but it doesn't work for XML:

  • Node with namespace are always considered unmatched
  • If an internal type has a "xml" annotation, the node will be unmatched

Result impact is a bloated additional property bag, with too many things.

This is complex to fix, and have little impact on usability right now, so keeping it as "enhancement" until someone really wants an additional property set that is perfect (and then needs slightly improved design for XML)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lmazuel
0